chrome/browser/ui/panels/panel_host.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_host.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc ('K') | « chrome/browser/ui/panels/panel_host.h ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_host.cc

diff --git a/chrome/browser/ui/panels/panel_host.cc b/chrome/browser/ui/panels/panel_host.cc

index 9d8bbd3d9c8bc73847a6539448051d12a258c7ff..670ae731fc4749e4ec88b0c47d1073fa1ee294a3 100644

--- a/chrome/browser/ui/panels/panel_host.cc

+++ b/chrome/browser/ui/panels/panel_host.cc

@@ -208,7 +208,7 @@ void PanelHost::RenderProcessGone(base::TerminationStatus status) {

CloseContents(web_contents_.get());

}

-void PanelHost::WebContentsDestroyed(content::WebContents* web_contents) {

+void PanelHost::WebContentsDestroyed() {

// Web contents should only be destroyed by us.

CHECK(!web_contents_.get());

Avi (use Gerrit) 2014/05/02 15:32:25 This line will explode, because you changed the se

zverre 2014/05/02 19:10:24 I think that everything is OK here because this is