chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/auto_login_infobar_delegate.cc ('k') | chrome/browser/ui/autofill/tab_autofill_manager_delegate.h » ('j') | chrome/browser/ui/panels/panel_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

index fd4573ffc48fad816f3686fe8c6db9119cb53f14..1a8a8944f2d8bb21cd87759e6b3f9a846c6b66bb 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

@@ -87,9 +87,9 @@ class AutofillPopupControllerBrowserTest

// Normally the WebContents will automatically delete the delegate, but here

// the delegate is owned by this test, so we have to manually destroy.

- virtual void WebContentsDestroyed(content::WebContents* web_contents)

+ virtual void WebContentsDestroyed()

OVERRIDE {

- DCHECK_EQ(web_contents_, web_contents);

+ DCHECK_EQ(web_contents_, web_contents());

autofill_external_delegate_.reset();

}