Suppress deprecation warnings in non-clang builds too

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ac6b2bb01f73a9d582e1900ef7255d318e001230..2771e7b93be15c216abe29b7fe10eb6a7c8d2711 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -79,12 +79,12 @@ config("icu_code") {
   } else if (is_linux || is_android) {
     cflags += [
       "-Wno-unused-function",
+      # ICU uses its own deprecated functions.
+      "-Wno-deprecated-declarations",
     ]
   }
   if (is_clang) {
     cflags += [
-      # ICU uses its own deprecated functions.
-      "-Wno-deprecated-declarations",

[Nico, 2016/12/12 15:00:53]

this breaks win/clang builds

[tsniatowski, 2016/12/12 15:04:21]

interesting. this exists already at around line 511, in a target that uses this
config already. squash all into one shared "if clang or android/linux" section
in the config?

[Nico, 2016/12/12 15:09:05]

Either that, or just keep these two lines here and add the two you're adding.
(See lhs of https://codereview.chromium.org/2492553006/diff/40001/BUILD.gn)

       # ICU has some code with the pattern:
       #   if (found = uprv_getWindowsTimeZoneInfo(...))
       "-Wno-parentheses",