Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2571313002: Remove some usage of |return XXX.release()| anti-pattern. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove some usage of |return XXX.release()| anti-pattern. Review-Url: https://codereview.chromium.org/2571313002 Committed: https://pdfium.googlesource.com/pdfium/+/5bed98c044a470e696e3b719d33cb5dc14aa7c32

Patch Set 1 #

Patch Set 2 : Android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M core/fpdfapi/font/cpdf_type3char.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 1 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Tom Sepez
Dan, ready for review.
4 years ago (2016-12-14 19:36:17 UTC) #4
dsinclair
lgtm
4 years ago (2016-12-14 19:37:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571313002/20001
4 years ago (2016-12-14 21:54:19 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 21:54:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/5bed98c044a470e696e3b719d33cb5dc14aa...

Powered by Google App Engine
This is Rietveld 408576698