Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: core/fpdfapi/page/cpdf_image.h

Issue 2571313002: Remove some usage of |return XXX.release()| anti-pattern. (Closed)
Patch Set: Android build Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/font/cpdf_type3char.cpp ('k') | core/fpdfapi/page/cpdf_image.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_ 7 #ifndef CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_
8 #define CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_ 8 #define CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_
9 9
10 #include <memory> 10 #include <memory>
(...skipping 26 matching lines...) Expand all
37 CPDF_Dictionary* GetOC() const { return m_pOC; } 37 CPDF_Dictionary* GetOC() const { return m_pOC; }
38 CPDF_Document* GetDocument() const { return m_pDocument; } 38 CPDF_Document* GetDocument() const { return m_pDocument; }
39 39
40 int32_t GetPixelHeight() const { return m_Height; } 40 int32_t GetPixelHeight() const { return m_Height; }
41 int32_t GetPixelWidth() const { return m_Width; } 41 int32_t GetPixelWidth() const { return m_Width; }
42 42
43 bool IsInline() const { return m_bIsInline; } 43 bool IsInline() const { return m_bIsInline; }
44 bool IsMask() const { return m_bIsMask; } 44 bool IsMask() const { return m_bIsMask; }
45 bool IsInterpol() const { return m_bInterpolate; } 45 bool IsInterpol() const { return m_bInterpolate; }
46 46
47 CFX_DIBSource* LoadDIBSource(CFX_DIBSource** ppMask = nullptr, 47 std::unique_ptr<CFX_DIBSource> LoadDIBSource(CFX_DIBSource** ppMask = nullptr,
48 uint32_t* pMatteColor = nullptr, 48 uint32_t* pMatteColor = nullptr,
49 bool bStdCS = false, 49 bool bStdCS = false,
50 uint32_t GroupFamily = 0, 50 uint32_t GroupFamily = 0,
51 bool bLoadMask = false) const; 51 bool bLoadMask = false) const;
52 52
53 void SetImage(const CFX_DIBitmap* pDIBitmap); 53 void SetImage(const CFX_DIBitmap* pDIBitmap);
54 void SetJpegImage(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile); 54 void SetJpegImage(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile);
55 void SetJpegImageInline(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile); 55 void SetJpegImageInline(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile);
56 56
57 void ResetCache(CPDF_Page* pPage, const CFX_DIBitmap* pDIBitmap); 57 void ResetCache(CPDF_Page* pPage, const CFX_DIBitmap* pDIBitmap);
58 58
59 bool StartLoadDIBSource(CPDF_Dictionary* pFormResource, 59 bool StartLoadDIBSource(CPDF_Dictionary* pFormResource,
60 CPDF_Dictionary* pPageResource, 60 CPDF_Dictionary* pPageResource,
61 bool bStdCS = false, 61 bool bStdCS = false,
(...skipping 16 matching lines...) Expand all
78 bool m_bIsInline = false; 78 bool m_bIsInline = false;
79 bool m_bIsMask = false; 79 bool m_bIsMask = false;
80 bool m_bInterpolate = false; 80 bool m_bInterpolate = false;
81 CPDF_Document* const m_pDocument; 81 CPDF_Document* const m_pDocument;
82 CFX_MaybeOwned<CPDF_Stream> m_pStream; 82 CFX_MaybeOwned<CPDF_Stream> m_pStream;
83 CFX_MaybeOwned<CPDF_Dictionary> m_pDict; 83 CFX_MaybeOwned<CPDF_Dictionary> m_pDict;
84 CPDF_Dictionary* m_pOC = nullptr; 84 CPDF_Dictionary* m_pOC = nullptr;
85 }; 85 };
86 86
87 #endif // CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_ 87 #endif // CORE_FPDFAPI_PAGE_CPDF_IMAGE_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/font/cpdf_type3char.cpp ('k') | core/fpdfapi/page/cpdf_image.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698