Remove StyleDifference::needsPaintPropertyUpdate()

Remove StyleDifference::needsPaintPropertyUpdate()

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667
Committed: https://crrev.com/e0f6787cf951fe2ba1895c2e1a68cb398da938fa
Cr-Commit-Position: refs/heads/master@{#438670}

[Xianzhu, 2016-12-14 18:55:30]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-12-14 18:55:31]

Wdyt?

[Xianzhu, 2016-12-14 19:01:08]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 19:02:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:45:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-12-14 21:06:17]

On 2016/12/14 at 18:55:31, wangxianzhu wrote:
> Wdyt?

How will we solve the cssClipChanged issue without this mechanism? For example,
a css clip is added.

[Xianzhu, 2016-12-14 21:41:12]

On 2016/12/14 21:06:17, pdr. wrote:
> On 2016/12/14 at 18:55:31, wangxianzhu wrote:
> > Wdyt?
> 
> How will we solve the cssClipChanged issue without this mechanism? For
example,
> a css clip is added.

StyleDifference::cssClipChanged() will still be set. The difference is how we
set needsPaintPropertyUpdate: perviously through
StyleDifference::needsPaintPropertyUpdate(), now directly by checking
cssClipChanged().

[pdr., 2016-12-14 21:42:07]

On 2016/12/14 at 21:41:12, wangxianzhu wrote:
> On 2016/12/14 21:06:17, pdr. wrote:
> > On 2016/12/14 at 18:55:31, wangxianzhu wrote:
> > > Wdyt?
> > 
> > How will we solve the cssClipChanged issue without this mechanism? For
example,
> > a css clip is added.
> 
> StyleDifference::cssClipChanged() will still be set. The difference is how we
set needsPaintPropertyUpdate: perviously through
StyleDifference::needsPaintPropertyUpdate(), now directly by checking
cssClipChanged().

ohh, I see. I agree. LGTM

[Xianzhu, 2016-12-14 21:47:52]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-14 21:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2571283002/#ps40001
(title: "Fix layout test failures")

[commit-bot: I haz the power, 2016-12-14 21:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:25:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481752072871940,
"parent_rev": "d266cc036b249a4b2d240e05a03c7df249fc2e8b", "commit_rev":
"e537a5aea0d052291971cdc4a389368b2cb91a0e"}

[commit-bot: I haz the power, 2016-12-14 23:25:31]

Description was changed from

==========
Remove StyleDifference::needsPaintPropertyUpdate()

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667
==========

to

==========
Remove StyleDifference::needsPaintPropertyUpdate()

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667

Review-Url: https://codereview.chromium.org/2571283002
==========

[commit-bot: I haz the power, 2016-12-14 23:25:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 23:28:23]

Description was changed from

==========
Remove StyleDifference::needsPaintPropertyUpdate()

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667

Review-Url: https://codereview.chromium.org/2571283002
==========

to

==========
Remove StyleDifference::needsPaintPropertyUpdate()

After looked into several paint property update issues, I feel that
the flag has little use. Most of situations needing paint property
update can't be derived from only style difference. It seems better to
keep needsPaintPropertyUpdate in layout and paint modules.

BUG=645667

Committed: https://crrev.com/e0f6787cf951fe2ba1895c2e1a68cb398da938fa
Cr-Commit-Position: refs/heads/master@{#438670}
==========

[commit-bot: I haz the power, 2016-12-14 23:28:24]

Patchset 3 (id:??) landed as
https://crrev.com/e0f6787cf951fe2ba1895c2e1a68cb398da938fa
Cr-Commit-Position: refs/heads/master@{#438670}