Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2571283002: Remove StyleDifference::needsPaintPropertyUpdate() (Closed)
Patch Set: Fix layout test failures Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 1709 matching lines...) Expand 10 before | Expand all | Expand 10 after
1720 1720
1721 if (diff.needsPaintInvalidationSubtree() || 1721 if (diff.needsPaintInvalidationSubtree() ||
1722 updatedDiff.needsPaintInvalidationSubtree()) 1722 updatedDiff.needsPaintInvalidationSubtree())
1723 setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(); 1723 setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
1724 else if (diff.needsPaintInvalidationObject() || 1724 else if (diff.needsPaintInvalidationObject() ||
1725 updatedDiff.needsPaintInvalidationObject()) 1725 updatedDiff.needsPaintInvalidationObject())
1726 setShouldDoFullPaintInvalidation(); 1726 setShouldDoFullPaintInvalidation();
1727 1727
1728 // Text nodes share style with their parents but the paint properties don't 1728 // Text nodes share style with their parents but the paint properties don't
1729 // apply to them, hence the !isText() check. 1729 // apply to them, hence the !isText() check.
1730 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && 1730 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && !isText() &&
1731 diff.needsPaintPropertyUpdate() && !isText()) { 1731 (diff.transformChanged() || diff.opacityChanged() ||
1732 diff.zIndexChanged() || diff.filterChanged() ||
1733 diff.backdropFilterChanged() || diff.cssClipChanged())) {
1732 setNeedsPaintPropertyUpdate(); 1734 setNeedsPaintPropertyUpdate();
1733 1735
1734 // We don't need to invalidate paint of objects on SPv2 when only paint 1736 // We don't need to invalidate paint of objects on SPv2 when only paint
1735 // property or paint order change. Mark the painting layer needing repaint 1737 // property or paint order change. Mark the painting layer needing repaint
1736 // for changed paint property or paint order. Raster invalidation will be 1738 // for changed paint property or paint order. Raster invalidation will be
1737 // issued if needed during paint. 1739 // issued if needed during paint.
1738 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 1740 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
1741 !shouldDoFullPaintInvalidation())
1739 ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint(); 1742 ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
1740 } 1743 }
1741 } 1744 }
1742 1745
1743 void LayoutObject::styleWillChange(StyleDifference diff, 1746 void LayoutObject::styleWillChange(StyleDifference diff,
1744 const ComputedStyle& newStyle) { 1747 const ComputedStyle& newStyle) {
1745 if (m_style) { 1748 if (m_style) {
1746 // If our z-index changes value or our visibility changes, 1749 // If our z-index changes value or our visibility changes,
1747 // we need to dirty our stacking context's z-order list. 1750 // we need to dirty our stacking context's z-order list.
1748 bool visibilityChanged = 1751 bool visibilityChanged =
(...skipping 1762 matching lines...) Expand 10 before | Expand all | Expand 10 after
3511 const blink::LayoutObject* root = object1; 3514 const blink::LayoutObject* root = object1;
3512 while (root->parent()) 3515 while (root->parent())
3513 root = root->parent(); 3516 root = root->parent();
3514 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3517 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3515 } else { 3518 } else {
3516 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3519 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3517 } 3520 }
3518 } 3521 }
3519 3522
3520 #endif 3523 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698