Remove unnecessary typedefs in third_party/fips181.

Remove unnecessary typedefs in third_party/fips181.

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=

Committed: https://crrev.com/d079621c94ee9e585014d28c02e7fc2df2edd0e7
Cr-Commit-Position: refs/heads/master@{#438657}

[palmer, 2016-12-14 01:08:37]

palmer@chromium.org changed reviewers:
+ wfh@chromium.org

[palmer, 2016-12-14 01:09:17]

wfh: PTAL. If you think this patch makes sense, I'll contact the upstream
developer.

[Will Harris, 2016-12-14 01:22:25]

lgtm but I would be happy to accept these as local modifications so please
update the README.chromium to reflect this.

I think the original library is C so adding bool breaks that compatibility.

[palmer, 2016-12-14 18:44:26]

> I think the original library is C so adding bool breaks that compatibility.

Not so; stdbool.h exists as of C99.

[Will Harris, 2016-12-14 18:46:28]

On 2016/12/14 18:44:26, palmer wrote:
> > I think the original library is C so adding bool breaks that compatibility.
> 
> Not so; stdbool.h exists as of C99.

did you mean to include stdbool.h then?

[palmer, 2016-12-14 18:50:14]

> did you mean to include stdbool.h then?

For our version, which has the files named .cc, we don't need to (bool is
already standard C++). If upstream takes this patch, and sticks with .c, they
will need to add #include <stdbool.h>, yes.

[Will Harris, 2016-12-14 19:09:01]

okay I'll leave it to your best judgement how to upstream this.

I'm happy with local modifications but if you go with this then please update
the README.chromium

[palmer, 2016-12-14 20:34:22]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-12-14 20:34:23]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2571113002/#ps40001
(title: "More commentary in the README.chromium.")

[commit-bot: I haz the power, 2016-12-14 20:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:24:38]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[palmer, 2016-12-14 21:43:49]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-12-14 21:43:49]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2571113002/#ps60001
(title: "Solve for MSVC warning C4805.")

[commit-bot: I haz the power, 2016-12-14 21:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-12-14 21:51:06]

On 2016/12/14 21:44:21, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

still lgtm - good luck upstreaming this :)

[commit-bot: I haz the power, 2016-12-14 22:54:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481751829081340,
"parent_rev": "e253e220fe19c8b98bfe702af61f4f007cc18eb5", "commit_rev":
"f16fd86b3649171e02f9d4bb213c451dcee31c91"}

[commit-bot: I haz the power, 2016-12-14 22:55:18]

Description was changed from

==========
Remove unnecessary typedefs in third_party/fips181.

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=
==========

to

==========
Remove unnecessary typedefs in third_party/fips181.

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=

Review-Url: https://codereview.chromium.org/2571113002
==========

[commit-bot: I haz the power, 2016-12-14 22:55:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 22:57:38]

Description was changed from

==========
Remove unnecessary typedefs in third_party/fips181.

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=

Review-Url: https://codereview.chromium.org/2571113002
==========

to

==========
Remove unnecessary typedefs in third_party/fips181.

Redefining these primitive types can cause problems; e.g. the definition of
|UINT32| is redundant, and conflicts with that in windows.h, if windows.h is
included before fips181's owntypes.h. These types are already available under
standardized names in stdbool.h and stdint.h.

BUG=

Committed: https://crrev.com/d079621c94ee9e585014d28c02e7fc2df2edd0e7
Cr-Commit-Position: refs/heads/master@{#438657}
==========

[commit-bot: I haz the power, 2016-12-14 22:57:39]

Patchset 4 (id:??) landed as
https://crrev.com/d079621c94ee9e585014d28c02e7fc2df2edd0e7
Cr-Commit-Position: refs/heads/master@{#438657}