third_party/fips181/README.chromium - Issue 2571113002: Remove unnecessary typedefs in third_party/fips181.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/fips181/README.chromium

Issue 2571113002: Remove unnecessary typedefs in third_party/fips181. (Closed)

Patch Set: Solve for MSVC warning C4805. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/fips181/README.chromium

diff --git a/third_party/fips181/README.chromium b/third_party/fips181/README.chromium

index 93af1b4473cecb42db8fc535c6a5dba53af06e5a..83a354b1eedaffca04af6500f4205ba37de7b5f9 100644

--- a/third_party/fips181/README.chromium

+++ b/third_party/fips181/README.chromium

@@ -12,5 +12,14 @@ Generator (APG).

Local Modifications:

-pronpass.c and pronpass.h were imported as files fips181.cc and fips181.h

+pronpass.c and pronpass.h were imported as files fips181.cc and fips181.h.

+owntypes.h was removed and the calling code changed to use standard C99/C++

+types. (At least 1 typedef (UINT32) conflicted with the same typedef in

+windows.h.) Although the upstream code is vanilla C, bool is available without

+stdbool.h here because we compile the code as C++. Vanilla C users must include

+that header.

+Additionally, some variables and a function (is_restricted_symbol) have had

+their types changed from int to bool (they were being used as bools). This

+allows us to build the code warning-free in MSVC (warning C4805).

« no previous file with comments | « third_party/fips181/BUILD.gn ('k') | third_party/fips181/convert.cc » ('j') | no next file with comments »