Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2570783002:
MD Settings: actually hide subpage and open-in-new indicators when inactive (Closed)
|
Created:
4 years ago by Dan Beam Modified:
4 years ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: actually hide subpage and open-in-new indicators when inactive
R=dschuyler@chromium.org,stevenjb@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8df3ed22fc96abbfd296388f3af28bc270ada096
Cr-Commit-Position: refs/heads/master@{#438274}
Patch Set 1 #
Total comments: 2
Patch Set 2 : . #Messages
Total messages: 15 (9 generated)
Description was changed from ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org BUG= ========== to ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dbeam@chromium.org changed reviewers: + stevenjb@chromium.org
Description was changed from ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org,stevenjb@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm https://codereview.chromium.org/2570783002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2570783002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:47: } Is the [is='paper-icon-button-light'] qualifier helpful here? For setting background-image it makes sense, since we care about how the button is being displayed, but conceptually wouldn't we want the display behavior for any button.subpage-arrow (or .icon-external)? It just seems like it would make the CSS here a little easier to read.
https://codereview.chromium.org/2570783002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2570783002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:47: } On 2016/12/13 18:28:10, stevenjb wrote: > Is the [is='paper-icon-button-light'] qualifier helpful here? For setting > background-image it makes sense, since we care about how the button is being > displayed, but conceptually wouldn't we want the display behavior for any > button.subpage-arrow (or .icon-external)? It just seems like it would make the > CSS here a little easier to read. there's a functional difference when it comes to specificity here, possibly https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity I agree that just .subpage-arrow, .icon-external { display: none; } [actionable] :-webkit-any(.subpage-arrow, .icon-external), [actionable]:-webkit-any(.subpage-arrow, .icon-external) { display: block; } would be easier to read. I've tried this and it seems to be fine.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2570783002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481656064601250,
"parent_rev": "f154d8894da49fd883f5342e1f0166460269625a", "commit_rev":
"1298423cc2cc75a2ac1df15bce6d22a4ba11da5d"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org,stevenjb@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org,stevenjb@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570783002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org,stevenjb@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2570783002 ========== to ========== MD Settings: actually hide subpage and open-in-new indicators when inactive R=dschuyler@chromium.org,stevenjb@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8df3ed22fc96abbfd296388f3af28bc270ada096 Cr-Commit-Position: refs/heads/master@{#438274} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8df3ed22fc96abbfd296388f3af28bc270ada096 Cr-Commit-Position: refs/heads/master@{#438274} |
