MD Settings: actually hide subpage and open-in-new indicators when inactive

chrome/browser/resources/settings/settings_shared_css.html

 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 <link rel="import" href="/settings_vars_css.html">
 
 <!-- Common styles for Material Design settings. -->
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
       /* Included here so we don't have to include "iron-positioning" in every
        * stylesheet. See crbug.com/498405. */
       [hidden] {
         display: none !important;
       }
 
       button[is='paper-icon-button-light'] {
         -webkit-margin-end: -8px;  /* Allow ripple to overlap the end. */
         -webkit-margin-start: 16px;
         background-position: center;
         background-repeat: no-repeat;
         background-size: var(--settings-icon-size);
         flex-shrink: 0;
         height: var(--settings-icon-ripple-size);
         width: var(--settings-icon-ripple-size);
       }
 
       :host-context([dir=rtl]) button[is='paper-icon-button-light'] {
         transform: scaleX(-1);  /* Flip on the X axis (aka mirror). */
       }
 
-      [actionable] button[is='paper-icon-button-light'].subpage-arrow {
+      button[is='paper-icon-button-light'].subpage-arrow {
         background-image: url(images/arrow_right.svg);
       }
 
-      [actionable] button[is='paper-icon-button-light'].icon-external {
+      button[is='paper-icon-button-light'].icon-external {
         background-image: url(images/open_in_new.svg);
       }
 
+      button[is='paper-icon-button-light'].subpage-arrow,
+      button[is='paper-icon-button-light'].icon-external {
+        display: none;
+      }
+
+      [actionable] button[is='paper-icon-button-light'].subpage-arrow,
+      [actionable] button[is='paper-icon-button-light'].icon-external,
+      button[is='paper-icon-button-light'][actionable].subpage-arrow,
+      button[is='paper-icon-button-light'][actionable].icon-external {
+        display: block;
+      }

[stevenjb, 2016/12/13 18:28:10]

Is the [is='paper-icon-button-light'] qualifier helpful here? For setting
background-image it makes sense, since we care about how the button is being
displayed, but conceptually wouldn't we want the display behavior for any
button.subpage-arrow (or .icon-external)? It just seems like it would make the
CSS here a little easier to read.

[Dan Beam, 2016/12/13 19:04:14]

there's a functional difference when it comes to specificity here, possibly

https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity

I agree that just

.subpage-arrow,
.icon-external {
  display: none;
}

[actionable] :-webkit-any(.subpage-arrow, .icon-external),
[actionable]:-webkit-any(.subpage-arrow, .icon-external) {
  display: block;
}

would be easier to read.  I've tried this and it seems to be fine.

+
       :host-context([dir=rtl]) paper-icon-button[icon='settings:arrow-back'] {
         transform: scaleX(-1);  /* Flip on the X axis (aka mirror). */
       }
 
       /* Use <h2> as the "sub-header" mentioned in the UX design docs. */
       h2 {
         align-items: center;
         align-self: flex-start;
         color: var(--paper-grey-600);
         display: flex;
@@ skipping 389 matching lines @@
       /* Turns the arrow direction downwards, when the bubble is placed above
        * the anchor element */
       .search-bubble-innards.above::after {
         -webkit-transform: rotate(-135deg);
         bottom: -5px;
         top: auto;
       }
     </style>
   </template>
 </dom-module>