Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2570693003: Move Task Scheduler Initialization From ios/chrome/browser to Web (Closed)

Created:
4 years ago by robliao
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Task Scheduler Initialization From ios/chrome/browser to Web Web appears to actually be the owner of the process running a browser. As such, it stands to reason that it should be the one initializing and controlling the lifetime of the task scheduler. This mirrors the Chrome change at https://codereview.chromium.org/2539263003/ BUG=662052 Committed: https://crrev.com/792b01c0f3d5c1bc6f1ced7d1385da7684367140 Cr-Commit-Position: refs/heads/master@{#438370}

Patch Set 1 #

Patch Set 2 : Merge Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -98 lines) Patch
D components/task_scheduler_util/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D components/task_scheduler_util/initialization_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/task_scheduler_util/initialization_util.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 1 5 chunks +8 lines, -27 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 1 4 chunks +72 lines, -0 lines 0 comments Download
M ios/web/public/web_client.h View 2 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (16 generated)
robliao
eugenebut@chromium.org: Please review this CL. Thanks!
4 years ago (2016-12-13 23:17:27 UTC) #11
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-14 00:34:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570693003/60001
4 years ago (2016-12-14 00:55:37 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-14 01:01:18 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-14 01:04:06 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/792b01c0f3d5c1bc6f1ced7d1385da7684367140
Cr-Commit-Position: refs/heads/master@{#438370}

Powered by Google App Engine
This is Rietveld 408576698