Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 2569863003: Move SetupMetrics() to PreMainMessageLoopRun (Closed)

Created:
4 years ago by robliao
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org, gab, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SetupMetrics() to PreMainMessageLoopRun This allows the Browser Task Scheduler to initialize during CreateThreads since SetupMetrics() ultimately requires use of the blocking pool. The blocking pool has to be redirected by the Browser Task Scheduler before this point Originating Chrome Change: http://crrev.com/1892c914719015f06c135127fd1dfd13dec39d33 BUG=662052 Committed: https://crrev.com/e39f2306910b799fae4537e9e0e97f44121e1333 Cr-Commit-Position: refs/heads/master@{#438367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ios/chrome/browser/ios_chrome_main_parts.mm View 3 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
robliao
sdefresne: Please review this change. Thanks!
4 years ago (2016-12-13 06:52:28 UTC) #4
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-14 00:43:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569863003/1
4 years ago (2016-12-14 00:44:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 00:52:30 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 00:54:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39f2306910b799fae4537e9e0e97f44121e1333
Cr-Commit-Position: refs/heads/master@{#438367}

Powered by Google App Engine
This is Rietveld 408576698