chromecast/android/DEPS - Issue 2570623003: [Chromecast] Turn CastContentWindow into an abstract interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/android/DEPS

Issue 2570623003: [Chromecast] Turn CastContentWindow into an abstract interface. (Closed)

Patch Set: Set user data outside of contructor Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/android/DEPS

diff --git a/chromecast/android/DEPS b/chromecast/android/DEPS

index 42eeb3278af1ec8cfcecf433f64dfbe53119f3c3..6897eef6ba91a395e3f9c33d05e3be2f5901eec2 100644

--- a/chromecast/android/DEPS

+++ b/chromecast/android/DEPS

@@ -2,5 +2,5 @@ include_rules = [

"+jni",

# TODO(sanfin): Remove cyclic dependency between content and android.

- "!chromecast/browser/android",

+ "+chromecast/browser/android",

byungchul 2016/12/16 22:52:22 Why?

derekjchow1 2016/12/17 00:13:07 cast_jni_registrar.cc needs to register JNI functi

byungchul 2016/12/17 00:57:37 That's the problem I think. It should not depend o

derekjchow1 2016/12/19 17:51:31 Done. I creates a browser/android specific jni reg

]

« no previous file with comments | « no previous file | chromecast/android/cast_jni_registrar.cc » ('j') | chromecast/browser/BUILD.gn » ('J')