[Chromecast] Turn CastContentWindow into an abstract interface.

chromecast/browser/BUILD.gn

Index: chromecast/browser/BUILD.gn
diff --git a/chromecast/browser/BUILD.gn b/chromecast/browser/BUILD.gn
index 2897c93aa602c6941ebdfbed1c06d2b9b9d14d38..abb59eee4be01c1fba9cf44daf60673bfbca5919 100644
--- a/chromecast/browser/BUILD.gn
+++ b/chromecast/browser/BUILD.gn
@@ -13,10 +13,6 @@ if (is_android) {
 
 source_set("browser") {
   sources = [
-    "android/cast_window_android.cc",
-    "android/cast_window_android.h",
-    "android/cast_window_manager.cc",
-    "android/cast_window_manager.h",
     "cast_browser_context.cc",
     "cast_browser_context.h",
     "cast_browser_main_parts.cc",
@@ -25,7 +21,6 @@ source_set("browser") {
     "cast_browser_process.h",
     "cast_content_browser_client.cc",
     "cast_content_browser_client.h",
-    "cast_content_window.cc",
     "cast_content_window.h",
     "cast_download_manager_delegate.cc",
     "cast_download_manager_delegate.h",
@@ -123,6 +118,8 @@ source_set("browser") {
 
   if (is_linux) {
     sources += [
+      "cast_content_window_linux.cc",
+      "cast_content_window_linux.h",

[byungchul, 2016/12/16 22:52:22]

In the past, gyp file specified all files and let ninja pick platform-specific
files accordingly. Is it changed for BUILD.gn?

[derekjchow1, 2016/12/17 00:13:07]

It's not changed but it's not well known either. I've been bitten by this
behaviour before actually (I though an internal file named *_linux file could be
included in an android build).

My preference is to be explicit and leave them in these if statements, rather
than depend on the BUILD.gn behaviour.

       "cast_memory_pressure_monitor.cc",
       "cast_memory_pressure_monitor.h",
       "metrics/external_metrics.cc",
@@ -135,6 +132,13 @@ source_set("browser") {
       "//ui/aura",
     ]
   } else if (is_android) {
+    sources += [
+      "android/cast_content_window_android.cc",
+      "android/cast_content_window_android.h",
+      "android/cast_web_contents_activity.cc",
+      "android/cast_web_contents_activity.h",
+    ]
+
     deps += [ ":jni_headers" ]
   }
 
@@ -214,11 +218,11 @@ source_set("unittests") {
 if (is_android) {
   generate_jni("jni_headers") {
     sources = [
+      "android/apk/src/org/chromium/chromecast/shell/CastContentWindowAndroid.java",
       "android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java",
       "android/apk/src/org/chromium/chromecast/shell/CastMetricsHelper.java",
       "android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroid.java",
-      "android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java",
-      "android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java",
+      "android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java",
     ]
 
     jni_package = "chromecast"