chromecast/android/DEPS - Issue 2570623003: [Chromecast] Turn CastContentWindow into an abstract interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/android/DEPS

Issue 2570623003: [Chromecast] Turn CastContentWindow into an abstract interface. (Closed)

Patch Set: Set user data outside of contructor Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+jni",	2 "+jni",

3	3

4 # TODO(sanfin): Remove cyclic dependency between content and android.	4 # TODO(sanfin): Remove cyclic dependency between content and android.

5 "!chromecast/browser/android",	5 "+chromecast/browser/android",
	byungchul 2016/12/16 22:52:22 Why? Why? derekjchow1 2016/12/17 00:13:07 cast_jni_registrar.cc needs to register JNI functi Show quoted text On 2016/12/16 22:52:22, byungchul wrote: > Why? cast_jni_registrar.cc needs to register JNI functions defined in chroemcast/browser/android. byungchul 2016/12/17 00:57:37 That's the problem I think. It should not depend o Show quoted text On 2016/12/17 00:13:07, derekjchow1 wrote: > On 2016/12/16 22:52:22, byungchul wrote: > > Why? > > cast_jni_registrar.cc needs to register JNI functions defined in > chroemcast/browser/android. That's the problem I think. It should not depend on shell. shell/android should have its own jni registration function. derekjchow1 2016/12/19 17:51:31 Done. I creates a browser/android specific jni reg Show quoted text On 2016/12/17 00:57:37, byungchul wrote: > On 2016/12/17 00:13:07, derekjchow1 wrote: > > On 2016/12/16 22:52:22, byungchul wrote: > > > Why? > > > > cast_jni_registrar.cc needs to register JNI functions defined in > > chroemcast/browser/android. > > That's the problem I think. It should not depend on shell. shell/android should > have its own jni registration function. Done. I creates a browser/android specific jni registration function. Also when looking closer at this directory, I determined we can remove this dependency completely.
6 ]	6 ]

OLD	NEW

« no previous file with comments | « no previous file | chromecast/android/cast_jni_registrar.cc » ('j') | chromecast/browser/BUILD.gn » ('J')