Strip units string in legacy perf dashboard JSON generator

Strip units string in legacy perf dashboard JSON generator

C++ tests that run on Windows upload units that have \r at the end because we
never strip the units field and units happen to be positioned at the very ends
of lines processed by this script.

BUG=670168
Committed: https://crrev.com/d07e4d61d4e028719202666c839c09629f574ce7
Cr-Commit-Position: refs/heads/master@{#438341}

[eakuefner, 2016-12-13 18:14:58]

eakuefner@chromium.org changed reviewers:
+ eyaich@chromium.org, sullivan@chromium.org

[eakuefner, 2016-12-13 18:14:59]

PTAL

Emily, is your chromium.org account the one you'd like to receive reviews at?
Your codereview name for this address is 'eyaich1' whereas for your corp account
it's 'eyaich' -- if this is the right account it'd be a little clearer if you
switched them.

[eyaich1, 2016-12-13 18:54:44]

lgtm

Yes the @chromium.org one is the right one, I will look into updating the
nickname.

[eakuefner, 2016-12-13 19:00:39]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-12-13 19:00:39]

Thanks!

[commit-bot: I haz the power, 2016-12-13 19:01:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:26:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eakuefner, 2016-12-13 20:29:32]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-12-13 20:29:33]

The patchset sent to the CQ was uploaded after l-g-t-m from eyaich@chromium.org
Link to the patchset: https://codereview.chromium.org/2570593005/#ps20001
(title: "fix incantation")

[commit-bot: I haz the power, 2016-12-13 20:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:35:56]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[eakuefner, 2016-12-13 22:44:35]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:48:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481669075390600,
"parent_rev": "b59e0817b00adc3f7e577a00807ae486ee54c745", "commit_rev":
"d25f525c557fe87ba649364f8b5ce2dbdb98360a"}

[commit-bot: I haz the power, 2016-12-13 23:48:39]

Description was changed from

==========
Strip units string in legacy perf dashboard JSON generator

C++ tests that run on Windows upload units that have \r at the end because we
never strip the units field and units happen to be positioned at the very ends
of lines processed by this script.

BUG=670168
==========

to

==========
Strip units string in legacy perf dashboard JSON generator

C++ tests that run on Windows upload units that have \r at the end because we
never strip the units field and units happen to be positioned at the very ends
of lines processed by this script.

BUG=670168

Review-Url: https://codereview.chromium.org/2570593005
==========

[commit-bot: I haz the power, 2016-12-13 23:48:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 23:53:09]

Description was changed from

==========
Strip units string in legacy perf dashboard JSON generator

C++ tests that run on Windows upload units that have \r at the end because we
never strip the units field and units happen to be positioned at the very ends
of lines processed by this script.

BUG=670168

Review-Url: https://codereview.chromium.org/2570593005
==========

to

==========
Strip units string in legacy perf dashboard JSON generator

C++ tests that run on Windows upload units that have \r at the end because we
never strip the units field and units happen to be positioned at the very ends
of lines processed by this script.

BUG=670168

Committed: https://crrev.com/d07e4d61d4e028719202666c839c09629f574ce7
Cr-Commit-Position: refs/heads/master@{#438341}
==========

[commit-bot: I haz the power, 2016-12-13 23:53:10]

Patchset 2 (id:??) landed as
https://crrev.com/d07e4d61d4e028719202666c839c09629f574ce7
Cr-Commit-Position: refs/heads/master@{#438341}