tools/perf/generate_legacy_perf_dashboard_json.py - Issue 2570593005: Strip units string in legacy perf dashboard JSON generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/generate_legacy_perf_dashboard_json.py

Issue 2570593005: Strip units string in legacy perf dashboard JSON generator (Closed)

Patch Set: fix incantation Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/generate_legacy_perf_dashboard_json.py

diff --git a/tools/perf/generate_legacy_perf_dashboard_json.py b/tools/perf/generate_legacy_perf_dashboard_json.py

index 69dc8ba7ad7e2fc704b9b872b3a6ad9c9677d98c..c44583766dc833d69cc7af699a2512af40dd3d46 100755

--- a/tools/perf/generate_legacy_perf_dashboard_json.py

+++ b/tools/perf/generate_legacy_perf_dashboard_json.py

@@ -139,7 +139,7 @@ class LegacyResultsProcessor(object):

trace_name = match_dict['TRACE'].strip()

graph = self._graphs.get(graph_name, self.Graph())

- graph.units = match_dict['UNITS'] or ''

+ graph.units = (match_dict['UNITS'] or '').strip()

trace = graph.traces.get(trace_name, self.Trace())

trace.value = match_dict['VALUE']

trace.important = match_dict['IMPORTANT'] or False

« no previous file with comments | « no previous file | no next file » | no next file with comments »