Add support for link repros and use it on net_perftests.

Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous builder to get a repro for some linker failures that we're observing. Having a link repro is the only way for us to report this kind of error to Microsoft in order for them to fix it (we haven't been able to reproduce this linker failure locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Committed: https://crrev.com/a6de346489e98bfac8bab14062decd759e905b15
Cr-Commit-Position: refs/heads/master@{#438621}

[Sébastien Marchand, 2016-12-12 22:41:20]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org, scottmg@chromium.org

[Sébastien Marchand, 2016-12-12 22:41:21]

Wdyt of this approach?

[scottmg, 2016-12-13 00:03:23]

It's a bit ugly to make all the directories, but seems OK to me for this sort of
debugging given that it's when the flag's on.

lgtm

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:48: # Root directory the will store the MSVC
link repro. This should only be used
"the will store" -> "that will store" (?)

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:51: # should add somethink like this to their
configuration:
somethink -> something

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:56: # Note that doing a link repro uses a lot
of disk space and slow down the
slow -> slows

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:57: # build, so this shouldn't be enabled on
too many targets.
Add a crbug link here.

[Sébastien Marchand, 2016-12-13 00:14:26]

Thanks, I'd prefer NOT to generate all these empty directories (and to only
generate the needed ones) but it looks like it'll require some architectural
changes and I don't think that it's worth it...

Waiting a little bit before landing this in case Bruce want to review it (and I
won't plug it in the recipe before tomorrow anyway, so there's no rush).

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:48: # Root directory the will store the MSVC
link repro. This should only be used
On 2016/12/13 00:03:23, scottmg wrote:
> "the will store" -> "that will store" (?)

Done.

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:51: # should add somethink like this to their
configuration:
On 2016/12/13 00:03:23, scottmg wrote:
> somethink -> something

Ark, 2 typos in 5 lines, sorry for that.

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:56: # Note that doing a link repro uses a lot
of disk space and slow down the
On 2016/12/13 00:03:23, scottmg wrote:
> slow -> slows

Done.

https://codereview.chromium.org/2570483004/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:57: # build, so this shouldn't be enabled on
too many targets.
On 2016/12/13 00:03:23, scottmg wrote:
> Add a crbug link here.

Done.

[Sébastien Marchand, 2016-12-13 00:14:40]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 00:16:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-13 00:18:52]

lgtm, assuming it works locally.

[Sébastien Marchand, 2016-12-13 00:20:23]

yep, works fine locally.

[commit-bot: I haz the power, 2016-12-13 02:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:08:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sébastien Marchand, 2016-12-13 02:10:06]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-12-13 02:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2570483004/#ps20001
(title: "Address Scott's comments.")

[commit-bot: I haz the power, 2016-12-13 02:10:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:20:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sébastien Marchand, 2016-12-13 03:20:27]

Description was changed from

==========
Add support for link repros and use it on net_perftests.

BUG=669854
==========

to

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
==========

[Sébastien Marchand, 2016-12-13 03:20:59]

sebmarchand@chromium.org changed reviewers:
+ bengr@chromium.org

[Sébastien Marchand, 2016-12-13 03:21:00]

+bengr@ for net/BUILD.gn owner approval.

[Sébastien Marchand, 2016-12-14 19:43:10]

Description was changed from

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
==========

to

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org
==========

[Sébastien Marchand, 2016-12-14 19:43:16]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:43:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:14:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481744596059820,
"parent_rev": "11c2d8fc1f6f5c8ebfa7d0d0f022f375de79f33a", "commit_rev":
"f8df0c78b4c18414656f9f97b9b32a74dc41d2c4"}

[commit-bot: I haz the power, 2016-12-14 21:14:42]

Description was changed from

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org
==========

to

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2570483004
==========

[commit-bot: I haz the power, 2016-12-14 21:14:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 21:16:39]

Description was changed from

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2570483004
==========

to

==========
Add support for link repros and use it on net_perftests.

This is a debugging feature that will be used on the official Win64 continuous
builder to get a repro for some linker failures that we're observing. Having a
link repro is the only way for us to report this kind of error to Microsoft in
order for them to fix it (we haven't been able to reproduce this linker failure
locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Committed: https://crrev.com/a6de346489e98bfac8bab14062decd759e905b15
Cr-Commit-Position: refs/heads/master@{#438621}
==========

[commit-bot: I haz the power, 2016-12-14 21:16:40]

Patchset 2 (id:??) landed as
https://crrev.com/a6de346489e98bfac8bab14062decd759e905b15
Cr-Commit-Position: refs/heads/master@{#438621}