Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: net/BUILD.gn

Issue 2570483004: Add support for link repros and use it on net_perftests. (Closed)
Patch Set: Address Scott's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index edacd2fc245713c3039fd2aeedd785515f795690..e71b431f06ea6e20a6c8bfa54b993395d4ad59e2 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -1596,6 +1596,13 @@ if (!is_ios) {
} else {
sources -= [ "proxy/proxy_resolver_perftest.cc" ]
}
+
+ # Some linker failures have been observed for this target on the Win64
+ # continuous builder, see crbug.com/659369.
+ # TODO(sebmarchand): Remove this once we have some data.
+ if (is_win && linkrepro_root_dir != "") {
+ ldflags = [ "/LINKREPRO:" + linkrepro_root_dir + "/" + target_name ]
+ }
}
}
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698