Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2570463006: Add histogram for Online/Offline Reading List display (Closed)

Created:
4 years ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier, olivierrobin
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram for Online/Offline Reading List display This CL records if the Reading List entry is displayed as the online or offline version. BUG=651041 Committed: https://crrev.com/7a40c625883275e67700c966af64b1b41fba64d3 Cr-Commit-Position: refs/heads/master@{#440743}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
gambard
PTAL.
4 years ago (2016-12-13 14:07:02 UTC) #2
gambard
ping. Should this wait until we change the offline/online logic?
4 years ago (2016-12-15 15:59:48 UTC) #3
Olivier
On 2016/12/15 15:59:48, gambard wrote: > ping. > Should this wait until we change the ...
4 years ago (2016-12-15 16:07:39 UTC) #4
gambard
PTAL.
3 years, 12 months ago (2016-12-23 09:41:13 UTC) #5
Olivier
This will report an histogram every time the page is displayed. See with mardini if ...
3 years, 12 months ago (2016-12-23 09:56:28 UTC) #7
gambard
ping as the behavior is defined.
3 years, 12 months ago (2016-12-27 08:26:30 UTC) #8
Olivier
lgtm
3 years, 12 months ago (2016-12-27 08:29:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570463006/20001
3 years, 12 months ago (2016-12-27 08:34:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-27 08:45:34 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a40c625883275e67700c966af64b1b41fba64d3
Cr-Commit-Position: refs/heads/master@{#440743}

Powered by Google App Engine
This is Rietveld 408576698