Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2570463006: Add histogram for Online/Offline Reading List display (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
index cc079b7f22260e31bad64e48c6d1e0296d87a41b..408fd76e3f46c2592088cd060778696d72d58c7a 100644
--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
@@ -7,6 +7,7 @@
#import <Foundation/Foundation.h>
#include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
#include "components/reading_list/ios/reading_list_model.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#include "ios/chrome/browser/chrome_url_constants.h"
@@ -150,6 +151,7 @@ void ReadingListWebStateObserver::PageLoaded(
if (load_completion_status == web::PageLoadCompletionStatus::SUCCESS) {
reading_list_model_->SetReadStatus(pending_url_, true);
+ UMA_HISTOGRAM_BOOLEAN("ReadingList.OfflineVersionDisplayed", false);
} else {
LoadOfflineReadingListEntry(item);
}
@@ -217,4 +219,5 @@ void ReadingListWebStateObserver::LoadOfflineReadingListEntry(
item->SetVirtualURL(pending_url_);
web_state()->GetNavigationManager()->Reload(false);
reading_list_model_->SetReadStatus(entry->URL(), true);
+ UMA_HISTOGRAM_BOOLEAN("ReadingList.OfflineVersionDisplayed", true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698