Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2570413002: Revert of [Telemetry] Increase timeout after sending SIGTERM (Closed)

Created:
4 years ago by eyaich1
Modified:
4 years ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Increase timeout after sending SIGTERM (patchset #2 id:20001 of https://codereview.chromium.org/2568033003/ ) Reason for revert: Testing to see if it caused the issue on Linux on the waterfall: https://bugs.chromium.org/p/chromium/issues/detail?id=674146 Original issue's description: > [Telemetry] Increase timeout after sending SIGTERM > > To shut down the browser on desktop, we first try to quit the browser normally, > then send SIGTERM, then wait a while, then send SIGKILL if we still don't see > that the browser is shut down. > > Apparently, with CHROME_HEADLESS=1, we should be getting a .dmp file on > SIGTERM, but we see no such file. > > kbr@ suggests that this may simply be because we're not waiting long enough. > The best result of this CL would be that we start getting useful stack traces > from these launch failures. > > BUG=catapult:#3074 > > Review-Url: https://codereview.chromium.org/2568033003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e6e0862c81652393de2dd878322e8c0c1e43d428 TBR=kbr@chromium.org,nednguyen@google.com,eakuefner@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#3074 Review-Url: https://codereview.chromium.org/2570413002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6a5ce5c1dff46439e735135316e21b7355dde479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eyaich1
Created Revert of [Telemetry] Increase timeout after sending SIGTERM
4 years ago (2016-12-14 19:50:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2570413002/1
4 years ago (2016-12-14 19:50:30 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-14 20:19:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698