[Telemetry] Increase timeout after sending SIGTERM

[Telemetry] Increase timeout after sending SIGTERM

To shut down the browser on desktop, we first try to quit the browser normally,
then send SIGTERM, then wait a while, then send SIGKILL if we still don't see
that the browser is shut down.

Apparently, with CHROME_HEADLESS=1, we should be getting a .dmp file on
SIGTERM, but we see no such file.

kbr@ suggests that this may simply be because we're not waiting long enough.
The best result of this CL would be that we start getting useful stack traces
from these launch failures.

BUG=catapult:#3074

Review-Url: https://codereview.chromium.org/2568033003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e6e0862c81652393de2dd878322e8c0c1e43d428

[eakuefner, 2016-12-12 22:08:55]

eakuefner@chromium.org changed reviewers:
+ kbr@chromium.org, nednguyen@google.com

[eakuefner, 2016-12-12 22:08:55]

PTAL

[nednguyen, 2016-12-13 00:29:23]

lgtm

[Ken Russell (switch to Gerrit), 2016-12-13 01:18:36]

LGTM

https://codereview.chromium.org/2568033003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2568033003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:619:
py_utils.WaitFor(lambda: not self.IsBrowserRunning(), timeout=20)
Suggest adding a comment about why this was changed.

[eakuefner, 2016-12-13 01:24:48]

https://codereview.chromium.org/2568033003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2568033003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:619:
py_utils.WaitFor(lambda: not self.IsBrowserRunning(), timeout=20)
On 2016/12/13 at 01:18:36, Ken Russell wrote:
> Suggest adding a comment about why this was changed.

Done.

[eakuefner, 2016-12-13 01:24:49]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-12-13 01:24:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2568033003/#ps20001
(title: "Address Ken's comment")

[commit-bot: I haz the power, 2016-12-13 01:24:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:43:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481592289374520,
"parent_rev": "c69690acc34b8be0d85596bc5ad40fce7502817a", "commit_rev":
"e6e0862c81652393de2dd878322e8c0c1e43d428"}

[commit-bot: I haz the power, 2016-12-13 01:43:25]

Description was changed from

==========
[Telemetry] Increase timeout after sending SIGTERM

To shut down the browser on desktop, we first try to quit the browser normally,
then send SIGTERM, then wait a while, then send SIGKILL if we still don't see
that the browser is shut down.

Apparently, with CHROME_HEADLESS=1, we should be getting a .dmp file on
SIGTERM, but we see no such file.

kbr@ suggests that this may simply be because we're not waiting long enough.
The best result of this CL would be that we start getting useful stack traces
from these launch failures.

BUG=catapult:#3074
==========

to

==========
[Telemetry] Increase timeout after sending SIGTERM

To shut down the browser on desktop, we first try to quit the browser normally,
then send SIGTERM, then wait a while, then send SIGKILL if we still don't see
that the browser is shut down.

Apparently, with CHROME_HEADLESS=1, we should be getting a .dmp file on
SIGTERM, but we see no such file.

kbr@ suggests that this may simply be because we're not waiting long enough.
The best result of this CL would be that we start getting useful stack traces
from these launch failures.

BUG=catapult:#3074

Review-Url: https://codereview.chromium.org/2568033003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-12-13 01:43:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[eyaich1, 2016-12-14 19:50:21]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2570413002/ by eyaich@chromium.org.

The reason for reverting is: Testing to see if it caused the issue on Linux on
the waterfall: https://bugs.chromium.org/p/chromium/issues/detail?id=674146.