[MD History] Fix toolbar dates in grouped mode.

[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570253002
Cr-Commit-Position: refs/heads/master@{#444976}
Committed: https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78ed4f992976400

[calamity, 2016-12-14 04:44:01]

Description was changed from

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
==========

to

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-12-15 01:47:20]

Patchset #1 (id:1) has been deleted

[calamity, 2016-12-15 02:17:52]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-12-15 02:17:52]

https://codereview.chromium.org/2570253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2570253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:58: queryInfo: Object,
Just FYI, I considered adding a couple more String properties here but if the
same values ever came back when the range changed, (e.g switching from Week to
Month on the 7th), then the computed value wouldn't get updated. So....
queryInfo it is.

[tsergeant, 2016-12-15 06:31:37]

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_grouped_list_test.js (right):

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:98:
app.set('queryState_.range', HistoryRange.MONTH);
This test is a bit confusing to read. The most relevant line is setting the
range, but it appears really far from the assertion. There's also two identical
chunks of code. My suggestion for how to lay it out:

<create and setup info>

app.set(range to month)
app.historyResult
assertEquals

app.historyResult(createHistoryInfo(), [])  // Reset the test

app.set(range to week)
app.historyResult
assertEquals

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:99: var info =
createHistoryInfo();
Also, should the new info fields appear in createHistoryInfo? They're expected
to be there now, I guess.

(If you do that, then maybe you don't need to duplicate the createHistoryInfo()
block?)

[calamity, 2016-12-15 06:57:00]

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_grouped_list_test.js (right):

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:98:
app.set('queryState_.range', HistoryRange.MONTH);
On 2016/12/15 06:31:37, tsergeant wrote:
> This test is a bit confusing to read. The most relevant line is setting the
> range, but it appears really far from the assertion. There's also two
identical
> chunks of code. My suggestion for how to lay it out:
> 
> <create and setup info>
> 
> app.set(range to month)
> app.historyResult
> assertEquals
> 
> app.historyResult(createHistoryInfo(), [])  // Reset the test
> 
> app.set(range to week)
> app.historyResult
> assertEquals

How about this?

https://codereview.chromium.org/2570253002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_grouped_list_test.js:99: var info =
createHistoryInfo();
On 2016/12/15 06:31:37, tsergeant wrote:
> Also, should the new info fields appear in createHistoryInfo? They're expected
> to be there now, I guess.
> 
> (If you do that, then maybe you don't need to duplicate the
createHistoryInfo()
> block?)

Hmm. So, the way this test is set up actually implicitly caught the issue that I
mentioned in the comment. I think this kind of real world scenario is nicer.

[tsergeant, 2016-12-15 22:35:48]

lgtm

[calamity, 2016-12-16 02:19:50]

calamity@chromium.org changed reviewers:
+ jshin@chromium.org

[calamity, 2016-12-16 02:19:51]

+jshin for base/i18n OWNERS.

[calamity, 2016-12-16 02:21:10]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 02:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:03:43]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[jungshik at Google, 2016-12-16 09:08:38]

See the comment below.

https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:535:
TimeFormatWeekdayMonthAndDay(query_results_info->end_time));
Instead of concatenating two dates, it'd be better to use ICU's
DateIntervalFormat. See
https://goo.gl/PdQ3Oz. Then, we can save one message (from grd) and JS call site
would be simpler, too. 

UErrorCode status = U_ZERO_ERROR;
std::unique_ptr<icu::DateIntervalFormat>
      formatter(icu::DateIntervalFormat::createInstance(UDAT_MONTH_WEEKDAY_DAY,
status));

icu::FieldPosition pos = 0;
UDate start_date = static_cast<Udate>(query_results_info->start_time.ToDoubleT()
* 1000;
UDate end_date = .... ; 
icu::DateInterval interval(start_date, end_date);
icu::UnicodeString formatted = formatter->format(&interval, formatted, pos,
status);
results_info.SetString("queryInternval", string16(formatted.getBuffer(),
static_cast<size_t>(formatted.length());

[calamity, 2016-12-19 04:12:55]

Happy Googleversary!

https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:535:
TimeFormatWeekdayMonthAndDay(query_results_info->end_time));
On 2016/12/16 09:08:38, jungshik at google wrote:
> Instead of concatenating two dates, it'd be better to use ICU's
> DateIntervalFormat. See
> https://goo.gl/PdQ3Oz. Then, we can save one message (from grd) and JS call
site
> would be simpler, too. 
> 
> UErrorCode status = U_ZERO_ERROR;
> std::unique_ptr<icu::DateIntervalFormat>
>      
formatter(icu::DateIntervalFormat::createInstance(UDAT_MONTH_WEEKDAY_DAY,
> status));
> 
> icu::FieldPosition pos = 0;
> UDate start_date =
static_cast<Udate>(query_results_info->start_time.ToDoubleT()
> * 1000;
> UDate end_date = .... ; 
> icu::DateInterval interval(start_date, end_date);
> icu::UnicodeString formatted = formatter->format(&interval, formatted, pos,
> status);
> results_info.SetString("queryInternval", string16(formatted.getBuffer(),
> static_cast<size_t>(formatted.length());

But this doesn't allow for a translated word separator? This only renders the
date as Tuesday, 7 November - Monday, 13 November whereas the current designs
specify Tuesday, 7 November to Monday, 13 November.

[jungshik at Google, 2016-12-19 07:19:22]

On 2016/12/19 04:12:55, calamity wrote:
> Happy Googleversary!
> 
>
https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/browsing_history_handler.cc (right):
> 
>
https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/browsing_history_handler.cc:535:
> TimeFormatWeekdayMonthAndDay(query_results_info->end_time));
> On 2016/12/16 09:08:38, jungshik at google wrote:
> > Instead of concatenating two dates, it'd be better to use ICU's
> > DateIntervalFormat. See
> > https://goo.gl/PdQ3Oz. Then, we can save one message (from grd) and JS call
> site
> > would be simpler, too. 
> > 
> > UErrorCode status = U_ZERO_ERROR;
> > std::unique_ptr<icu::DateIntervalFormat>
> >      
> formatter(icu::DateIntervalFormat::createInstance(UDAT_MONTH_WEEKDAY_DAY,
> > status));
> > 
> > icu::FieldPosition pos = 0;
> > UDate start_date =
> static_cast<Udate>(query_results_info->start_time.ToDoubleT()
> > * 1000;
> > UDate end_date = .... ; 
> > icu::DateInterval interval(start_date, end_date);
> > icu::UnicodeString formatted = formatter->format(&interval, formatted, pos,
> > status);
> > results_info.SetString("queryInternval", string16(formatted.getBuffer(),
> > static_cast<size_t>(formatted.length());
> 
> But this doesn't allow for a translated word separator? This only renders the
> date as Tuesday, 7 November - Monday, 13 November whereas the current designs
> specify Tuesday, 7 November to Monday, 13 November.

'-' is used in English, but CLDR (used by ICU) may have a different separator
for other locales. (it's up to the locale data in CLDR). 

BTW, using a separator in words (e.g. 'to' in English) may not be such a good
idea because 'to' in other languages may need to be inflected depending on
what comes before or after that. (e.g. November or Monday in your example).

[calamity, 2016-12-20 03:11:48]

On 2016/12/19 07:19:22, jungshik at google wrote:
> On 2016/12/19 04:12:55, calamity wrote:
> > Happy Googleversary!
> > 
> >
>
https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
> > File chrome/browser/ui/webui/browsing_history_handler.cc (right):
> > 
> >
>
https://codereview.chromium.org/2570253002/diff/40001/chrome/browser/ui/webui...
> > chrome/browser/ui/webui/browsing_history_handler.cc:535:
> > TimeFormatWeekdayMonthAndDay(query_results_info->end_time));
> > On 2016/12/16 09:08:38, jungshik at google wrote:
> > > Instead of concatenating two dates, it'd be better to use ICU's
> > > DateIntervalFormat. See
> > > https://goo.gl/PdQ3Oz. Then, we can save one message (from grd) and JS
call
> > site
> > > would be simpler, too. 
> > > 
> > > UErrorCode status = U_ZERO_ERROR;
> > > std::unique_ptr<icu::DateIntervalFormat>
> > >      
> > formatter(icu::DateIntervalFormat::createInstance(UDAT_MONTH_WEEKDAY_DAY,
> > > status));
> > > 
> > > icu::FieldPosition pos = 0;
> > > UDate start_date =
> > static_cast<Udate>(query_results_info->start_time.ToDoubleT()
> > > * 1000;
> > > UDate end_date = .... ; 
> > > icu::DateInterval interval(start_date, end_date);
> > > icu::UnicodeString formatted = formatter->format(&interval, formatted,
pos,
> > > status);
> > > results_info.SetString("queryInternval", string16(formatted.getBuffer(),
> > > static_cast<size_t>(formatted.length());
> > 
> > But this doesn't allow for a translated word separator? This only renders
the
> > date as Tuesday, 7 November - Monday, 13 November whereas the current
designs
> > specify Tuesday, 7 November to Monday, 13 November.
> 
> '-' is used in English, but CLDR (used by ICU) may have a different separator
> for other locales. (it's up to the locale data in CLDR). 
> 
> BTW, using a separator in words (e.g. 'to' in English) may not be such a good
> idea because 'to' in other languages may need to be inflected depending on
> what comes before or after that. (e.g. November or Monday in your example).

Okay, I'll check with our designer, thanks.

[calamity, 2017-01-05 07:18:51]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 07:19:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 08:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 08:40:02]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-06 00:28:12]

Our designer is fine with this. I updated the CL to use the date interval
formatter. Can you PTAL?

Thanks

[jungshik at Google, 2017-01-10 01:12:29]

Sorry for the delay. See my comments below. 
The first comment does not require any action if you feel strongly about hiding
ICU enums.

https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
File base/i18n/time_formatting.h (right):

https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
base/i18n/time_formatting.h:47: };
I have a mixed feeling about insulating callers from ICU enums. If there's a
non-ICU implementation, it makes a perfect sense, but we don't have any.   I'm
aware that other APIs do something similar here.

https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:533:
base::DATE_FORMAT_MONTH_WEEKDAY_DAY));
Don't you 'base::' for DateIntervalFormat... and TimeFormatMon....?

[calamity, 2017-01-16 02:41:17]

Patchset #5 (id:100001) has been deleted

[calamity, 2017-01-16 02:49:25]

https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
File base/i18n/time_formatting.h (right):

https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
base/i18n/time_formatting.h:47: };
On 2017/01/10 01:12:29, jungshik at Google (ooo) wrote:
> I have a mixed feeling about insulating callers from ICU enums. If there's a
> non-ICU implementation, it makes a perfect sense, but we don't have any.   I'm
> aware that other APIs do something similar here. 
> 

I would prefer the ICU enums get hidden, just because they're harder to find.
Figuring out that you need to include e.g dtitvfmt.h, isn't something I'd want
all clients of this code to have to think about. I think they should have a
chrome API that's nicely insulated from the grittier ICU implementation details.

https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:533:
base::DATE_FORMAT_MONTH_WEEKDAY_DAY));
On 2017/01/10 01:12:29, jungshik at Google (ooo) wrote:
> Don't you 'base::' for DateIntervalFormat... and TimeFormatMon....? 

Huh. surprisingly this worked without it. Probably some funky C++ name
resolution rules.

Fixed.

[jungshik at Google, 2017-01-18 20:08:07]

On 2017/01/16 02:49:25, calamity wrote:
>
https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
> File base/i18n/time_formatting.h (right):
> 
>
https://codereview.chromium.org/2570253002/diff/60001/base/i18n/time_formatti...
> base/i18n/time_formatting.h:47: };
> On 2017/01/10 01:12:29, jungshik at Google (ooo) wrote:
> > I have a mixed feeling about insulating callers from ICU enums. If there's a
> > non-ICU implementation, it makes a perfect sense, but we don't have any.  
I'm
> > aware that other APIs do something similar here. 
> > 
> 
> I would prefer the ICU enums get hidden, just because they're harder to find.
> Figuring out that you need to include e.g dtitvfmt.h, isn't something I'd want
> all clients of this code to have to think about. I think they should have a
> chrome API that's nicely insulated from the grittier ICU implementation
details.
> 
>
https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/browsing_history_handler.cc (right):
> 
>
https://codereview.chromium.org/2570253002/diff/60001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/browsing_history_handler.cc:533:
> base::DATE_FORMAT_MONTH_WEEKDAY_DAY));
> On 2017/01/10 01:12:29, jungshik at Google (ooo) wrote:
> > Don't you 'base::' for DateIntervalFormat... and TimeFormatMon....? 
> 
> Huh. surprisingly this worked without it. Probably some funky C++ name
> resolution rules.
> 
> Fixed.

Thanks, LGTM !

[calamity, 2017-01-19 04:35:59]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-01-19 04:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2570253002/#ps120001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-19 04:36:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:49:29]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[calamity, 2017-01-19 06:04:07]

Patchset #5 (id:120001) has been deleted

[calamity, 2017-01-19 06:04:09]

Patchset #4 (id:80001) has been deleted

[calamity, 2017-01-19 06:19:03]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 06:19:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-01-19 06:23:18]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2017-01-19 06:23:25]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-01-19 06:23:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/2570253002/#ps140001
(title: "rebase, address comments")

[commit-bot: I haz the power, 2017-01-19 06:23:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 07:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 07:27:45]

Failed to apply patch for
chrome/browser/resources/md_history/app.vulcanized.html:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/md_history/app.vulcanized.html:213
  error: chrome/browser/resources/md_history/app.vulcanized.html: patch does not
apply

Patch:       chrome/browser/resources/md_history/app.vulcanized.html
Index: chrome/browser/resources/md_history/app.vulcanized.html
diff --git a/chrome/browser/resources/md_history/app.vulcanized.html
b/chrome/browser/resources/md_history/app.vulcanized.html
index
ab68c0b5595e8bf3a604a126c9d89bd13b8f70ba..9e23c6e5fd30b327ca14f97bfd9c9f45c7596b86
100644
--- a/chrome/browser/resources/md_history/app.vulcanized.html
+++ b/chrome/browser/resources/md_history/app.vulcanized.html
@@ -213,6 +213,7 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
     <defs>
       
       <g id="add"><path d="M19 13h-6v6h-2v-6H5v-2h6V5h2v6h6v2z"></path></g>
+      <g id="arrow-drop-up"><path d="M7 14l5-5 5 5z"></path></g>
       <g id="arrow-drop-down"><path d="M7 10l5 5 5-5z"></path></g>
       <g id="cancel"><path d="M12 2C6.47 2 2 6.47 2 12s4.47 10 10 10 10-4.47
10-10S17.53 2 12 2zm5 13.59L15.59 17 12 13.41 8.41 17 7 15.59 10.59 12 7 8.41
8.41 7 12 10.59 15.59 7 17 8.41 13.41 12 17 15.59z"></path></g>
 <if expr="chromeos">
@@ -227,6 +228,7 @@ subject to an additional IP rights grant found at
http://polymer.github.io/PATEN
       <g id="expand-more"><path d="M16.59 8.59L12 13.17 7.41 8.59 6 10l6 6
6-6z"></path></g>
       <g id="extension"><path d="M20.5 11H19V7c0-1.1-.9-2-2-2h-4V3.5C13 2.12
11.88 1 10.5 1S8 2.12 8 3.5V5H4c-1.1 0-1.99.9-1.99 2v3.8H3.5c1.49 0 2.7 1.21 2.7
2.7s-1.21 2.7-2.7 2.7H2V20c0 1.1.9 2 2 2h3.8v-1.5c0-1.49 1.21-2.7 2.7-2.7 1.49 0
2.7 1.21 2.7 2.7V22H17c1.1 0 2-.9 2-2v-4h1.5c1.38 0 2.5-1.12 2.5-2.5S21.88 11
20.5 11z"></path></g>
       <g id="file-download"><path d="M19 9h-4V3H9v6H5l7 7 7-7zM5
18v2h14v-2H5z"></path></g>
+      <g id="folder"><path d="M10 4H4c-1.1 0-1.99.9-1.99 2L2 18c0 1.1.9 2 2
2h16c1.1 0 2-.9 2-2V8c0-1.1-.9-2-2-2h-8l-2-2z"></path></g>
       <g id="fullscreen"><path d="M7 14H5v5h5v-2H7v-3zm-2-4h2V7h3V5H5v5zm12
7h-3v2h5v-5h-2v3zM14 5v2h3v3h2V5h-5z"></path></g>
       <g id="group"><path d="M16 11c1.66 0 2.99-1.34 2.99-3S17.66 5 16 5c-1.66
0-3 1.34-3 3s1.34 3 3 3zm-8 0c1.66 0 2.99-1.34 2.99-3S9.66 5 8 5C6.34 5 5 6.34 5
8s1.34 3 3 3zm0 2c-2.33 0-7 1.17-7 3.5V19h14v-2.5c0-2.33-4.67-3.5-7-3.5zm8
0c-.29 0-.62.02-.97.05 1.16.84 1.97 1.97 1.97
3.45V19h6v-2.5c0-2.33-4.67-3.5-7-3.5z"></path></g>
       <g id="menu"><path d="M3
18h18v-2H3v2zm0-5h18v-2H3v2zm0-7v2h18V6H3z"></path></g>
@@ -2463,7 +2465,7 @@ paper-tab {
         </paper-tabs>
         <div id="grouped-nav-container">
           <span id="grouped-date">
-            {{getHistoryInterval_(queryStartTime, queryEndTime)}}
+            [[getHistoryInterval_(queryInfo)]]
           </span>
           <button is="paper-icon-button-light" id="today-button"
class="icon-button" title="$i18n{rangeToday}" on-tap="onTodayTap_"
disabled="[[isToday_(groupedOffset)]]">
             <iron-icon icon="history:today"></iron-icon>
@@ -3322,7 +3324,7 @@ dialog .body {
       <history-list id="infinite-list" querying="[[queryState.querying]]"
searched-term="[[queryResult.info.term]]">
       </history-list>
       <template is="dom-if" if="[[grouped]]">
-        <history-grouped-list id="grouped-list" range="[[groupedRange]]"
query-start-time="[[queryResult.info.queryStartTime]]"
query-end-time="[[queryResult.info.queryEndTime]]"
searched-term="[[queryResult.info.term]]">
+        <history-grouped-list id="grouped-list" range="[[groupedRange]]"
query-interval="[[queryResult.info.queryInterval]]"
searched-term="[[queryResult.info.term]]">
         </history-grouped-list>
       </template>
     </iron-pages>
@@ -3778,7 +3780,7 @@ h1 {
 </style>
     <history-router selected-page="{{selectedPage_}}"
query-state="{{queryState_}}">
     </history-router>
-    <history-toolbar id="toolbar"
grouped-offset="{{queryState_.groupedOffset}}"
grouped-range="{{queryState_.range}}" has-drawer="[[hasDrawer_]]"
is-grouped-mode="{{grouped_}}"
query-end-time="[[queryResult_.info.queryEndTime]]"
has-more-results="[[!queryResult_.info.finished]]"
query-start-time="[[queryResult_.info.queryStartTime]]"
querying="[[queryState_.querying]]" search-term="{{queryState_.searchTerm}}"
show-menu-promo="[[showMenuPromo_]]"
show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]"
spinner-active="[[shouldShowSpinner_(queryState_.querying,
+    <history-toolbar id="toolbar"
grouped-offset="{{queryState_.groupedOffset}}"
grouped-range="{{queryState_.range}}" has-drawer="[[hasDrawer_]]"
has-more-results="[[!queryResult_.info.finished]]"
is-grouped-mode="{{grouped_}}" query-info="[[queryResult_.info]]"
querying="[[queryState_.querying]]" search-term="{{queryState_.searchTerm}}"
show-menu-promo="[[showMenuPromo_]]"
show-sync-notice="[[showSyncNotice_(hasSyncedResults, selectedPage_)]]"
spinner-active="[[shouldShowSpinner_(queryState_.querying,
                                              queryState_.incremental,
                                              queryState_.searchTerm)]]">
     </history-toolbar>

[calamity, 2017-01-20 00:36:08]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 00:37:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:52:48]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-20 03:58:03]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-01-20 03:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/2570253002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-20 03:58:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 04:05:30]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484884683217410,
"parent_rev": "0100cebc322f5356430cb4fed9f8a93102f78582", "commit_rev":
"a220c70742bf9de3bb7212c1c78ed4f992976400"}

[commit-bot: I haz the power, 2017-01-20 04:06:36]

Description was changed from

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570253002
Cr-Commit-Position: refs/heads/master@{#444976}
Committed:
https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78e...
==========

[commit-bot: I haz the power, 2017-01-20 04:06:37]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78e...

[agrieve, 2017-01-23 17:54:44]

On 2017/01/20 04:06:37, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:160001) as
>
https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78e...

This caused 16kb growth on Android (where I would guess from the description it
shouldn't affect)
Tracking: https://bugs.chromium.org/p/chromium/issues/detail?id=683386

[Wez, 2017-02-08 01:02:49]

Description was changed from

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570253002
Cr-Commit-Position: refs/heads/master@{#444976}
Committed:
https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78e...
==========

to

==========
[MD History] Fix toolbar dates in grouped mode.

This CL fixes the date format in the toolbar when the history page is in
grouped mode.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570253002
Cr-Commit-Position: refs/heads/master@{#444976}
Committed:
https://chromium.googlesource.com/chromium/src/+/a220c70742bf9de3bb7212c1c78e...
==========

[Wez, 2017-02-08 01:02:49]

wez@chromium.org changed reviewers:
+ jochen@chromium.org

[Wez, 2017-02-08 02:08:34]

Hallo jochen@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	components/history_strings.grdp
Thanks,
Wez

[jochen (gone - plz use gerrit), 2017-03-21 21:22:49]

lgtm