[MD History] Fix toolbar dates in grouped mode.

chrome/browser/ui/webui/browsing_history_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/browsing_history_handler.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <utility>
@@ skipping 506 matching lines @@
 
   // Add the specific dates that were searched to display them.
   // TODO(sergiu): Put today if the start is in the future.
   results_info.SetString(
       "queryStartTime",
       GetRelativeDateLocalized(clock_.get(), query_results_info->start_time));
   results_info.SetString(
       "queryEndTime",
       GetRelativeDateLocalized(clock_.get(), query_results_info->end_time));
 
+  results_info.SetString(
+      "queryStartMonth",
+      TimeFormatMonthAndYear(query_results_info->start_time));
+  results_info.SetString(
+      "queryStartTimeShort",
+      TimeFormatWeekdayMonthAndDay(query_results_info->start_time));
+  results_info.SetString(
+      "queryEndTimeShort",
+      TimeFormatWeekdayMonthAndDay(query_results_info->end_time));

[jungshik at Google, 2016/12/16 09:08:38]

Instead of concatenating two dates, it'd be better to use ICU's
DateIntervalFormat. See
https://goo.gl/PdQ3Oz. Then, we can save one message (from grd) and JS call site
would be simpler, too. 

UErrorCode status = U_ZERO_ERROR;
std::unique_ptr<icu::DateIntervalFormat>
      formatter(icu::DateIntervalFormat::createInstance(UDAT_MONTH_WEEKDAY_DAY,
status));

icu::FieldPosition pos = 0;
UDate start_date = static_cast<Udate>(query_results_info->start_time.ToDoubleT()
* 1000;
UDate end_date = .... ; 
icu::DateInterval interval(start_date, end_date);
icu::UnicodeString formatted = formatter->format(&interval, formatted, pos,
status);
results_info.SetString("queryInternval", string16(formatted.getBuffer(),
static_cast<size_t>(formatted.length());

[calamity, 2016/12/19 04:12:54]

But this doesn't allow for a translated word separator? This only renders the
date as Tuesday, 7 November - Monday, 13 November whereas the current designs
specify Tuesday, 7 November to Monday, 13 November.

+
   web_ui()->CallJavascriptFunctionUnsafe("historyResult", results_info,
                                          results_value);
 }
 
 void BrowsingHistoryHandler::OnRemoveVisitsComplete() {
   web_ui()->CallJavascriptFunctionUnsafe("deleteComplete");
 }
 
 void BrowsingHistoryHandler::OnRemoveVisitsFailed() {
   web_ui()->CallJavascriptFunctionUnsafe("deleteFailed");
 }
 
 void BrowsingHistoryHandler::HistoryDeleted() {
   web_ui()->CallJavascriptFunctionUnsafe("historyDeleted");
 }
 
 void BrowsingHistoryHandler::HasOtherFormsOfBrowsingHistory(
     bool has_other_forms,
     bool has_synced_results) {
     web_ui()->CallJavascriptFunctionUnsafe(
         "showNotification", base::FundamentalValue(has_synced_results),
         base::FundamentalValue(has_other_forms));
 }