Fix underflow correction occurring during normal rendering.

Fix underflow correction occurring during normal rendering.

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.

Committed: https://crrev.com/8ac9ef71a561a281bd867e23fcd31e129373ab37
Cr-Commit-Position: refs/heads/master@{#438596}

[DaleCurtis, 2016-12-14 01:06:38]

dalecurtis@chromium.org changed reviewers:
+ watk@chromium.org, wdzierzanowski@opera.com

[watk, 2016-12-14 01:25:37]

It certainly looks right, though I think wdzierzanowski is in a better position
to find bugs in this than I am. lgtm regardless.

[DaleCurtis, 2016-12-14 02:19:39]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:20:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:58:53]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-12-14 19:30:56]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-12-14 19:31:16]

wdzierzanowski@ approved on the bug, so I assume he meant to approve here.

[commit-bot: I haz the power, 2016-12-14 19:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:39:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481743856567440, "parent_rev":
"b6d1b6dd4feaff2101b566e691197a66f9317c7f", "commit_rev":
"b8413f14ce30551d0faba5c0a61b8aea4e62291d"}

[commit-bot: I haz the power, 2016-12-14 19:39:44]

Description was changed from

==========
Fix underflow correction occurring during normal rendering.

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.
==========

to

==========
Fix underflow correction occurring during normal rendering.

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.

Review-Url: https://codereview.chromium.org/2570013003
==========

[commit-bot: I haz the power, 2016-12-14 19:39:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 19:42:20]

Description was changed from

==========
Fix underflow correction occurring during normal rendering.

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.

Review-Url: https://codereview.chromium.org/2570013003
==========

to

==========
Fix underflow correction occurring during normal rendering.

We should not be trying to expire frames during the normal
rendering process. This corrects a conditional which was
incorrectly allowing this behavior and fixes the test which
were relying on this behavior.

Testing the inverse (i.e. what was broken) is not in this
CL, since I ran out of time to add it for now.

Notably, I wasn't able to reproduce any issues arising from
this mistake. In practice, Render() occurs with such frequency
that it's rare for FrameReady() to occur fast enough to out
pace it in a meaningful manner relative to the frame duration.

BUG=667704
TEST=updated unittests.

Committed: https://crrev.com/8ac9ef71a561a281bd867e23fcd31e129373ab37
Cr-Commit-Position: refs/heads/master@{#438596}
==========

[commit-bot: I haz the power, 2016-12-14 19:42:21]

Patchset 1 (id:??) landed as
https://crrev.com/8ac9ef71a561a281bd867e23fcd31e129373ab37
Cr-Commit-Position: refs/heads/master@{#438596}