[base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded

Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900
Committed: https://crrev.com/b15ce3fe194edc7abf68ad4587e7f0d141e7b2f5
Cr-Commit-Position: refs/heads/master@{#440061}

[maksims (do not use this acc), 2016-12-13 11:27:27]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 11:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-12-13 11:30:00]

Description was changed from

==========
[base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded

BUG=601900
==========

to

==========
[base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded

BUG=601900
==========

[maksims (do not use this acc), 2016-12-13 11:30:00]

maksim.sisov@intel.com changed reviewers:
+ hidehiko@chromium.org, miu@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:37:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[maksims (do not use this acc), 2016-12-13 11:42:04]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 11:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-12-13 11:43:55]

https://codereview.chromium.org/2569913003/diff/20001/base/time/time.cc
File base/time/time.cc (right):

https://codereview.chromium.org/2569913003/diff/20001/base/time/time.cc#newco...
base/time/time.cc:241: // This function must not fail.
miu, How do you think? Should a return value from FromLocalExploded be ignored
or should I put into DCHECK here? I don't think NOTREACHED() is needed here.

[commit-bot: I haz the power, 2016-12-13 12:12:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 12:12:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[maksims (do not use this acc), 2016-12-13 13:24:38]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 13:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-12-13 13:26:23]

Description was changed from

==========
[base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded

BUG=601900
==========

to

==========
Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900
==========

[maksims (do not use this acc), 2016-12-13 13:26:23]

maksim.sisov@intel.com changed reviewers:
+ halliwell@chromium.org

[maksims (do not use this acc), 2016-12-13 13:26:44]

+ halliwell@, please check chromecast

[commit-bot: I haz the power, 2016-12-13 13:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:43:26]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[halliwell, 2016-12-13 15:11:30]

https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/dump_info.cc (right):

https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/dump_info.cc:151: return
base::Time::FromLocalExploded(ex, &dump_);
should be dump_time_

[hidehiko, 2016-12-13 15:14:39]

+cc: fukino@.

google_apis LGTM.

[maksims (do not use this acc), 2016-12-13 16:55:38]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-12-13 16:56:36]

https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
File chromecast/crash/linux/dump_info.cc (right):

https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
chromecast/crash/linux/dump_info.cc:151: return
base::Time::FromLocalExploded(ex, &dump_);
On 2016/12/13 15:11:30, halliwell wrote:
> should be dump_time_ 

Done.

[commit-bot: I haz the power, 2016-12-13 18:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:42:39]

Dry run: This issue passed the CQ dry run.

[halliwell, 2016-12-13 20:08:57]

On 2016/12/13 16:56:36, maksims wrote:
>
https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
> File chromecast/crash/linux/dump_info.cc (right):
> 
>
https://codereview.chromium.org/2569913003/diff/40001/chromecast/crash/linux/...
> chromecast/crash/linux/dump_info.cc:151: return
> base::Time::FromLocalExploded(ex, &dump_);
> On 2016/12/13 15:11:30, halliwell wrote:
> > should be dump_time_ 
> 
> Done.

chromecast/ lgtm

[miu, 2016-12-13 20:23:56]

The CQ bit was checked by miu@chromium.org

[miu, 2016-12-13 20:23:57]

lgtm

[miu, 2016-12-13 20:23:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org
Link to the patchset: https://codereview.chromium.org/2569913003/#ps60001
(title: "typo")

[miu, 2016-12-13 20:24:14]

Thanks for the clean-up! :)

[commit-bot: I haz the power, 2016-12-13 20:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:24:49]

This CL has an open dependency (Issue 2090713003 Patch 480001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[maksims (do not use this acc), 2016-12-21 06:26:30]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-12-21 06:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, halliwell@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2569913003/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-12-21 06:26:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 09:30:40]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482301590494390,
"parent_rev": "07d9b76065454b65a1b8f35c5b95f79e19095236", "commit_rev":
"39e8ce03325861b49f407bef4f14c6d800c8a027"}

[commit-bot: I haz the power, 2016-12-21 09:31:08]

Description was changed from

==========
Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900
==========

to

==========
Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900

Review-Url: https://codereview.chromium.org/2569913003
==========

[commit-bot: I haz the power, 2016-12-21 09:31:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-21 09:33:43]

Description was changed from

==========
Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900

Review-Url: https://codereview.chromium.org/2569913003
==========

to

==========
Remove deprecated FromLocalExploded and FromUTCExploded and modify
left callers.

BUG=601900

Committed: https://crrev.com/b15ce3fe194edc7abf68ad4587e7f0d141e7b2f5
Cr-Commit-Position: refs/heads/master@{#440061}
==========

[commit-bot: I haz the power, 2016-12-21 09:33:45]

Patchset 5 (id:??) landed as
https://crrev.com/b15ce3fe194edc7abf68ad4587e7f0d141e7b2f5
Cr-Commit-Position: refs/heads/master@{#440061}