Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8727)

Unified Diff: chromecast/crash/linux/dump_info_unittest.cc

Issue 2569913003: [base::Time] Follow-up cl: Remove deprecated FromLocalExploded FromUTCExploded (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/dump_info.cc ('k') | google_apis/drive/drive_api_requests_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/dump_info_unittest.cc
diff --git a/chromecast/crash/linux/dump_info_unittest.cc b/chromecast/crash/linux/dump_info_unittest.cc
index 1e4d3814c3b579e7c7d2344cf64284155685bcc6..1817177fbe164fd41b62652e9633f7ce37f97fba 100644
--- a/chromecast/crash/linux/dump_info_unittest.cc
+++ b/chromecast/crash/linux/dump_info_unittest.cc
@@ -54,7 +54,8 @@ TEST(DumpInfoTest, AllRequiredFieldsIsValid) {
ex.day_of_month = 12;
ex.month = 11;
ex.year = 2001;
- base::Time dump_time = base::Time::FromLocalExploded(ex);
+ base::Time dump_time;
+ EXPECT_TRUE(base::Time::FromLocalExploded(ex, &dump_time));
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -92,7 +93,8 @@ TEST(DumpInfoTest, SomeRequiredFieldsEmptyIsValid) {
ex.day_of_month = 12;
ex.month = 11;
ex.year = 2001;
- base::Time dump_time = base::Time::FromLocalExploded(ex);
+ base::Time dump_time;
+ EXPECT_TRUE(base::Time::FromLocalExploded(ex, &dump_time));
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -125,7 +127,8 @@ TEST(DumpInfoTest, AllOptionalFieldsIsValid) {
ex.day_of_month = 12;
ex.month = 11;
ex.year = 2001;
- base::Time dump_time = base::Time::FromLocalExploded(ex);
+ base::Time dump_time;
+ EXPECT_TRUE(base::Time::FromLocalExploded(ex, &dump_time));
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
@@ -159,7 +162,8 @@ TEST(DumpInfoTest, SomeOptionalFieldsIsValid) {
ex.day_of_month = 12;
ex.month = 11;
ex.year = 2001;
- base::Time dump_time = base::Time::FromLocalExploded(ex);
+ base::Time dump_time;
+ EXPECT_TRUE(base::Time::FromLocalExploded(ex, &dump_time));
ASSERT_TRUE(info->valid());
ASSERT_EQ("name", info->params().process_name);
« no previous file with comments | « chromecast/crash/linux/dump_info.cc ('k') | google_apis/drive/drive_api_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698