Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569713002: [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a Cr-Commit-Position: refs/heads/master@{#437891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -58 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/UIView+SizeClassSupport.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/animation_util.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/background_generator.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/browser_otr_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/favicon_view.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/file_locations.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/image_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/native_content_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/native_content_controller.mm View 3 chunks +4 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reversed_animation.mm View 5 chunks +6 lines, -27 lines 0 comments Download
M ios/chrome/browser/ui/rtl_geometry.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/show_mail_composer_util.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/show_privacy_settings_util.mm View 1 chunk +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
stkhapugin
PTAL. Unfortunately I cannot test against the downstream bots (crbug.com/673354) right now.
4 years ago (2016-12-12 15:53:40 UTC) #4
marq (ping after 24h)
lgtm
4 years ago (2016-12-12 16:01:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569713002/1
4 years ago (2016-12-12 16:38:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 17:00:21 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a Cr-Commit-Position: refs/heads/master@{#437891}
4 years ago (2016-12-12 17:21:28 UTC) #14
rohitrao (ping after 24h)
4 years ago (2016-12-12 23:08:18 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2567203002/ by rohitrao@chromium.org.

The reason for reverting is: Speculatively reverting because downstream device
tests are failing..

Powered by Google App Engine
This is Rietveld 408576698