Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2567203002: Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2569713002/ ) Reason for revert: Speculatively reverting because downstream device tests are failing. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/54842ee261813f25854ace5fd23854238a3f544a > Cr-Commit-Position: refs/heads/master@{#437891} TBR=marq@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Committed: https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404 Cr-Commit-Position: refs/heads/master@{#437943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -78 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/UIView+SizeClassSupport.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/animation_util.mm View 2 chunks +1 line, -5 lines 0 comments Download
M ios/chrome/browser/ui/background_generator.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/browser_otr_state.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/favicon_view.mm View 3 chunks +5 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/file_locations.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/image_util.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/native_content_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/native_content_controller.mm View 3 chunks +10 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/reversed_animation.mm View 5 chunks +27 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/rtl_geometry.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/show_mail_composer_util.mm View 2 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/show_privacy_settings_util.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rohitrao (ping after 24h)
Created Revert of [ObjC ARC] Converts ios/chrome/browser/ui:ui to ARC.
4 years ago (2016-12-12 23:08:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567203002/1
4 years ago (2016-12-12 23:09:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 23:11:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/232afa8c76cdbc55d6a5d790c47dc1430b74e404 Cr-Commit-Position: refs/heads/master@{#437943}
4 years ago (2016-12-12 23:13:50 UTC) #8
stkhapugin
4 years ago (2016-12-13 10:56:23 UTC) #9
Message was sent while issue was closed.
I meant this one - lgtm. This had fixed the bots.

Powered by Google App Engine
This is Rietveld 408576698