Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2569683002: MIPS[64]: Disable fusion multiple-accumulate instructions (Closed)

Created:
4 years ago by ivica.bogosavljevic
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Disable fusion multiple-accumulate instructions MIPS[64]R6 supports only fusion multiply-accumulate instructions, and using these causes failures of several tests that expect exact floating-point results. Therefore we disable fusion multiply-accumulate in both emitted and compiled code on R6. TEST=cctest/test-run-machops/RunFloat64MulAndFloat64Add1,mjsunit/es6/math-expm1.js mjsunit/es6/math-fround.js,mjsunit/compiler/multiply-add.js BUG= Review-Url: https://codereview.chromium.org/2569683002 Cr-Commit-Position: refs/heads/master@{#41717} Committed: https://chromium.googlesource.com/v8/v8/+/ee7281f8ff8122953ed843f0815b8bbe59eacd93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -398 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +12 lines, -24 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 5 chunks +22 lines, -64 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +12 lines, -24 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +22 lines, -64 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +32 lines, -2 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 6 chunks +46 lines, -106 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 6 chunks +54 lines, -100 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
ivica.bogosavljevic
PTAL
4 years ago (2016-12-12 13:12:36 UTC) #2
Ilija.Pavlovic1
lgtm
4 years ago (2016-12-13 12:48:14 UTC) #4
miran.karic
lgtm
4 years ago (2016-12-14 13:05:14 UTC) #7
miran.karic
lgtm lgtm
4 years ago (2016-12-14 13:05:14 UTC) #8
ivica.bogosavljevic
I need lght from the owners of cctest.gyp and BUILD.gn in order to land this ...
4 years ago (2016-12-15 09:57:28 UTC) #12
Michael Achenbach
lgtm
4 years ago (2016-12-15 10:40:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569683002/1
4 years ago (2016-12-15 11:47:21 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 11:50:24 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ee7281f8ff8122953ed843f0815b8bbe59e...

Powered by Google App Engine
This is Rietveld 408576698