Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569603002: Remove the options plugin (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -179 lines) Patch
D pkg/analysis_server/lib/src/plugin/linter_plugin.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +0 lines, -3 lines 0 comments Download
D pkg/analysis_server/lib/src/services/linter/linter.dart View 1 chunk +0 lines, -52 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/plugin/options.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/lint/analysis.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 2 chunks +6 lines, -0 lines 0 comments Download
D pkg/analyzer/lib/src/plugin/options_plugin.dart View 1 chunk +0 lines, -50 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This also removes an unused plugin from server.
4 years ago (2016-12-10 22:14:47 UTC) #2
scheglov
LGTM
4 years ago (2016-12-10 23:02:45 UTC) #3
Brian Wilkerson
4 years ago (2016-12-11 16:38:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a01afcd1d1501159371368f291775b4a20b9ecdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698