Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: pkg/analysis_server/lib/src/services/linter/linter.dart

Issue 2569603002: Remove the options plugin (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/linter/linter.dart
diff --git a/pkg/analysis_server/lib/src/services/linter/linter.dart b/pkg/analysis_server/lib/src/services/linter/linter.dart
deleted file mode 100644
index 89dd0c849da979dddf42d8692522796735f35c96..0000000000000000000000000000000000000000
--- a/pkg/analysis_server/lib/src/services/linter/linter.dart
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library services.src.linter;
-
-import 'package:analyzer/analyzer.dart';
-import 'package:analyzer/plugin/options.dart';
-import 'package:analyzer/src/lint/registry.dart';
-import 'package:yaml/yaml.dart';
-
-/**
- * An error code indicating an undefined lint rule.
- *
- * Parameters:
- * 0: the rule name
- */
-const AnalysisOptionsWarningCode UNDEFINED_LINT_WARNING =
- const AnalysisOptionsWarningCode(
- 'UNDEFINED_LINT_WARNING', "'{0}' is not a recognized lint rule");
-
-/// Validates `linter` rule configurations.
-class LinterRuleOptionsValidator extends OptionsValidator {
- static const linter = 'linter';
- static const rulesKey = 'rules';
- @override
- List<AnalysisError> validate(
- ErrorReporter reporter, Map<String, YamlNode> options) {
- List<AnalysisError> errors = <AnalysisError>[];
- var node = options[linter];
- if (node is YamlMap) {
- var rules = node.nodes[rulesKey];
- validateRules(rules, reporter);
- }
- return errors;
- }
-
- validateRules(dynamic rules, ErrorReporter reporter) {
- if (rules is YamlList) {
- //TODO(pq): migrate this to a proper API once there is one.
- Iterable<String> registeredLints =
- Registry.ruleRegistry.map((r) => r.name);
- rules.nodes.forEach((YamlNode ruleNode) {
- Object value = ruleNode.value;
- if (value != null && !registeredLints.contains(value)) {
- reporter.reportErrorForSpan(
- UNDEFINED_LINT_WARNING, ruleNode.span, [value]);
- }
- });
- }
- }
-}
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analysis_server/test/analysis_abstract.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698