Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/analyzer/lib/src/task/options.dart

Issue 2569603002: Remove the options plugin (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/plugin/options_plugin.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/options.dart
diff --git a/pkg/analyzer/lib/src/task/options.dart b/pkg/analyzer/lib/src/task/options.dart
index 78a93c7f7b0b2735f8ab9647a9c330113af1d60e..6995b2af3f37d9c8045f0fb3e76c748bff32b12a 100644
--- a/pkg/analyzer/lib/src/task/options.dart
+++ b/pkg/analyzer/lib/src/task/options.dart
@@ -16,6 +16,7 @@ import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/utilities_general.dart';
import 'package:analyzer/src/lint/config.dart';
import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/options_rule_validator.dart';
import 'package:analyzer/src/lint/registry.dart';
import 'package:analyzer/src/task/general.dart';
import 'package:analyzer/src/util/yaml.dart';
@@ -390,16 +391,16 @@ class LinterOptionsValidator extends TopLevelOptionValidator {
/// Validates options defined in an analysis options file.
class OptionsFileValidator {
- // TODO(pq): move to an extension point.
+ /// The source being validated.
+ final Source source;
+
final List<OptionsValidator> _validators = [
new AnalyzerOptionsValidator(),
- new LinterOptionsValidator()
+ new LinterOptionsValidator(),
+ new LinterRuleOptionsValidator()
];
- final Source source;
- OptionsFileValidator(this.source) {
- _validators.addAll(AnalysisEngine.instance.optionsPlugin.optionsValidators);
- }
+ OptionsFileValidator(this.source);
List<AnalysisError> validate(Map<String, YamlNode> options) {
RecordingErrorListener recorder = new RecordingErrorListener();
« no previous file with comments | « pkg/analyzer/lib/src/plugin/options_plugin.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698