Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2569483003: [SPInvalidation] Workaround bug about out-of-flow positioned under column spanner (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Workaround bug about out-of-flow positioned under column spanner Force slow path for now, which is the same as what we are doing in PaintInvalidationState. BUG=672989 TEST=virtual/spinvalidation/fast/multicol/span/abspos-containing-block-outside-spanner.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/7390e830c109df123c871fda26ea889d64f2d198 Cr-Commit-Position: refs/heads/master@{#437727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Xianzhu
4 years ago (2016-12-09 23:47:54 UTC) #5
chrishtr
lgtm
4 years ago (2016-12-09 23:54:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569483003/1
4 years ago (2016-12-10 00:29:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 02:26:35 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 15:05:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7390e830c109df123c871fda26ea889d64f2d198
Cr-Commit-Position: refs/heads/master@{#437727}

Powered by Google App Engine
This is Rietveld 408576698