Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2569413002: Don't block GPU process access in single-process mode. (Closed)

Created:
4 years ago by Zhenyao Mo
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't block GPU process access in single-process mode. BUG=664488 TEST=content_unittests,gpu is enabled in win/NVidia R=kbr@chromium.org,kkinnunen@nvidia.com Committed: https://crrev.com/66731ee5c810af897ee9029a2054aca682091d30 Cr-Commit-Position: refs/heads/master@{#438612}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 3 chunks +13 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
Zhenyao Mo
Kimmo: this should give you back gpu in single-process mode. Kimmo or Ken: Please review.
4 years ago (2016-12-13 23:51:45 UTC) #3
Ken Russell (switch to Gerrit)
Seems fine. LGTM https://codereview.chromium.org/2569413002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.h File content/browser/gpu/gpu_data_manager_impl_private.h (right): https://codereview.chromium.org/2569413002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.h#newcode272 content/browser/gpu/gpu_data_manager_impl_private.h:272: // True is --single-process or --in-process-gpu ...
4 years ago (2016-12-14 01:02:31 UTC) #4
Zhenyao Mo
https://codereview.chromium.org/2569413002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.h File content/browser/gpu/gpu_data_manager_impl_private.h (right): https://codereview.chromium.org/2569413002/diff/1/content/browser/gpu/gpu_data_manager_impl_private.h#newcode272 content/browser/gpu/gpu_data_manager_impl_private.h:272: // True is --single-process or --in-process-gpu is passed in. ...
4 years ago (2016-12-14 18:41:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569413002/20001
4 years ago (2016-12-14 18:43:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 20:39:00 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 20:42:54 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66731ee5c810af897ee9029a2054aca682091d30
Cr-Commit-Position: refs/heads/master@{#438612}

Powered by Google App Engine
This is Rietveld 408576698