Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2569383002:
Enable ARM NEON in Blink if compiling with Clang (Closed)
|
Created:
4 years ago by Simon Hosie Modified:
4 years ago CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, Nico, esprehn Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable ARM NEON in Blink if compiling with Clang
Clang declares itself as GCC 4.2.1, which fails a GCC_VERSION test in wtf/CPU.h
and consequently disables NEON code in Blink.
BUG=673067
Change-Id: I1e7a28996ab4d016cbc3039556384f00fb3e7034
Committed: https://crrev.com/6a66b7eda01fb58b0393ecd4f8086ebab0f25e5a
Cr-Commit-Position: refs/heads/master@{#439903}
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thakis@chromium.org changed reviewers: + thakis@chromium.org
lgtm
Adding it to the CQ.
The CQ bit was checked by cavalcantii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The blocker issues have landed (https://codereview.chromium.org/2579773003/), I'm adding it to the CQ.
The CQ bit was checked by cavalcantii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by cavalcantii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482260571581900, "parent_rev":
"45d225c9c44be3386cedccaba9b1c150f1b2e975", "commit_rev":
"6eaa6c0df4720c65409fdbb8a683a2ec06066309"}
Message was sent while issue was closed.
Description was changed from ========== Enable ARM NEON in Blink if compiling with Clang Clang declares itself as GCC 4.2.1, which fails a GCC_VERSION test in wtf/CPU.h and consequently disables NEON code in Blink. BUG=673067 Change-Id: I1e7a28996ab4d016cbc3039556384f00fb3e7034 ========== to ========== Enable ARM NEON in Blink if compiling with Clang Clang declares itself as GCC 4.2.1, which fails a GCC_VERSION test in wtf/CPU.h and consequently disables NEON code in Blink. BUG=673067 Change-Id: I1e7a28996ab4d016cbc3039556384f00fb3e7034 Review-Url: https://codereview.chromium.org/2569383002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable ARM NEON in Blink if compiling with Clang Clang declares itself as GCC 4.2.1, which fails a GCC_VERSION test in wtf/CPU.h and consequently disables NEON code in Blink. BUG=673067 Change-Id: I1e7a28996ab4d016cbc3039556384f00fb3e7034 Review-Url: https://codereview.chromium.org/2569383002 ========== to ========== Enable ARM NEON in Blink if compiling with Clang Clang declares itself as GCC 4.2.1, which fails a GCC_VERSION test in wtf/CPU.h and consequently disables NEON code in Blink. BUG=673067 Change-Id: I1e7a28996ab4d016cbc3039556384f00fb3e7034 Committed: https://crrev.com/6a66b7eda01fb58b0393ecd4f8086ebab0f25e5a Cr-Commit-Position: refs/heads/master@{#439903} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6a66b7eda01fb58b0393ecd4f8086ebab0f25e5a Cr-Commit-Position: refs/heads/master@{#439903} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
