Legacy out-of-flow descendant propagation

Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619
Committed: https://crrev.com/c57031df82a809ebb6899d46c73b8f97f58980ff
Cr-Commit-Position: refs/heads/master@{#438359}

[atotic, 2016-12-13 17:21:44]

Description was changed from

==========
Legacy out-of-flow descendant propagation

BUG=635619
==========

to

==========
Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619
==========

[atotic, 2016-12-13 17:21:44]

atotic@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[atotic, 2016-12-13 17:21:56]

ptal

[ikilpatrick, 2016-12-13 18:28:27]

https://codereview.chromium.org/2569263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc (right):

https://codereview.chromium.org/2569263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc:34: //    
fragment->PhysicalFragment()->OutOfFlowDescendants();
why is this commented out?

[ikilpatrick, 2016-12-13 18:28:35]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[atotic, 2016-12-13 19:19:42]

https://codereview.chromium.org/2569263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc (right):

https://codereview.chromium.org/2569263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc:34: //    
fragment->PhysicalFragment()->OutOfFlowDescendants();
On 2016/12/13 at 18:28:27, ikilpatrick wrote:
> why is this commented out?

because oops. fixed.

[cbiesinger, 2016-12-13 20:59:06]

https://codereview.chromium.org/2569263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.h (right):

https://codereview.chromium.org/2569263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.h:64: void
UseOldOutOfFlowPositioning();
This does need a comment :)

[atotic, 2016-12-13 21:18:21]

Also added DCHECK instead of an 'if' guard.

ptal

https://codereview.chromium.org/2569263002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.h (right):

https://codereview.chromium.org/2569263002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.h:64: void
UseOldOutOfFlowPositioning();
On 2016/12/13 at 20:59:06, cbiesinger wrote:
> This does need a comment :)

done

// Call if this out-of-flow block needs to be positioned with
// legacy Layout.

[cbiesinger, 2016-12-13 21:45:45]

lgtm

[ikilpatrick, 2016-12-13 21:57:36]

lgtm with nits.

https://codereview.chromium.org/2569263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.h (right):

https://codereview.chromium.org/2569263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.h:65: // legacy Layout.
.nit wording.

Called if this is an out-of-flow block which needs to be positioned with legacy
layout.

[atotic, 2016-12-13 22:01:01]

https://codereview.chromium.org/2569263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.h (right):

https://codereview.chromium.org/2569263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.h:65: // legacy Layout.
On 2016/12/13 at 21:57:36, ikilpatrick wrote:
> .nit wording.
> 
> Called if this is an out-of-flow block which needs to be positioned with
legacy layout.

done

https://codereview.chromium.org/2569263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.h:65: // legacy Layout.
On 2016/12/13 at 21:57:36, ikilpatrick wrote:
> .nit wording.
> 
> Called if this is an out-of-flow block which needs to be positioned with
legacy layout.

done

[atotic, 2016-12-13 22:01:03]

The CQ bit was checked by atotic@chromium.org

[atotic, 2016-12-13 22:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2569263002/#ps60001
(title: "CR fixes, wording")

[commit-bot: I haz the power, 2016-12-13 22:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 00:28:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481666463036770,
"parent_rev": "76cd50ef726e2d2ea69e87f885dabf624c663221", "commit_rev":
"0084549e144c3365f356ec29c782159c5167bac1"}

[commit-bot: I haz the power, 2016-12-14 00:29:11]

Description was changed from

==========
Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619
==========

to

==========
Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619

Review-Url: https://codereview.chromium.org/2569263002
==========

[commit-bot: I haz the power, 2016-12-14 00:29:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 00:32:30]

Description was changed from

==========
Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619

Review-Url: https://codereview.chromium.org/2569263002
==========

to

==========
Legacy out-of-flow descendant propagation

Small part of my big patch: https://codereview.chromium.org/2568743005

BUG=635619

Committed: https://crrev.com/c57031df82a809ebb6899d46c73b8f97f58980ff
Cr-Commit-Position: refs/heads/master@{#438359}
==========

[commit-bot: I haz the power, 2016-12-14 00:32:31]

Patchset 4 (id:??) landed as
https://crrev.com/c57031df82a809ebb6899d46c73b8f97f58980ff
Cr-Commit-Position: refs/heads/master@{#438359}