Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

Issue 2569263002: Legacy out-of-flow descendant propagation (Closed)
Patch Set: CR fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGBlockNode_h 5 #ifndef NGBlockNode_h
6 #define NGBlockNode_h 6 #define NGBlockNode_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/ng_layout_input_node.h" 9 #include "core/layout/ng/ng_layout_input_node.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 void SetNextSibling(NGBlockNode*); 55 void SetNextSibling(NGBlockNode*);
56 void SetFirstChild(NGLayoutInputNode*); 56 void SetFirstChild(NGLayoutInputNode*);
57 57
58 DECLARE_VIRTUAL_TRACE(); 58 DECLARE_VIRTUAL_TRACE();
59 59
60 // Runs layout on layout_box_ and creates a fragment for the resulting 60 // Runs layout on layout_box_ and creates a fragment for the resulting
61 // geometry. 61 // geometry.
62 NGPhysicalFragment* RunOldLayout(const NGConstraintSpace&); 62 NGPhysicalFragment* RunOldLayout(const NGConstraintSpace&);
63 63
64 void UseOldOutOfFlowPositioning();
cbiesinger 2016/12/13 20:59:06 This does need a comment :)
atotic 2016/12/13 21:18:20 done // Call if this out-of-flow block needs to b
65
64 void UpdateLayoutBox(NGPhysicalFragment* fragment, 66 void UpdateLayoutBox(NGPhysicalFragment* fragment,
65 const NGConstraintSpace* constraint_space); 67 const NGConstraintSpace* constraint_space);
66 68
67 private: 69 private:
68 // This is necessary for interop between old and new trees -- after our parent 70 // This is necessary for interop between old and new trees -- after our parent
69 // positions us, it calls this function so we can store the position on the 71 // positions us, it calls this function so we can store the position on the
70 // underlying LayoutBox. 72 // underlying LayoutBox.
71 void PositionUpdated(); 73 void PositionUpdated();
72 74
73 bool CanUseNewLayout(); 75 bool CanUseNewLayout();
(...skipping 16 matching lines...) Expand all
90 92
91 DEFINE_TYPE_CASTS(NGBlockNode, 93 DEFINE_TYPE_CASTS(NGBlockNode,
92 NGLayoutInputNode, 94 NGLayoutInputNode,
93 node, 95 node,
94 node->Type() == NGLayoutInputNode::kLegacyBlock, 96 node->Type() == NGLayoutInputNode::kLegacyBlock,
95 node.Type() == NGLayoutInputNode::kLegacyBlock); 97 node.Type() == NGLayoutInputNode::kLegacyBlock);
96 98
97 } // namespace blink 99 } // namespace blink
98 100
99 #endif // NGBlockNode 101 #endif // NGBlockNode
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698