Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569213002: [ObjC ARC] Reland of Converts ios/chrome/browser/ui:ui to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Reland of Converts ios/chrome/browser/ui:ui to ARC. Reland of https://codereview.chromium.org/2569713002/ that was reverted with https://codereview.chromium.org/2567203002/ but turned out to not be the reason for the failures. Original CL description: Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f Cr-Commit-Position: refs/heads/master@{#438159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -58 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/UIView+SizeClassSupport.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/animation_util.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/background_generator.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/browser_otr_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/favicon_view.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/file_locations.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/image_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/native_content_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/native_content_controller.mm View 3 chunks +4 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/orientation_limiting_navigation_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reversed_animation.mm View 5 chunks +6 lines, -27 lines 0 comments Download
M ios/chrome/browser/ui/rtl_geometry.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/show_mail_composer_util.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/show_privacy_settings_util.mm View 1 chunk +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ui_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/uikit_ui_util.mm View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stkhapugin
PTAL and check CQ if lgty.
4 years ago (2016-12-13 12:57:10 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-13 13:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569213002/1
4 years ago (2016-12-13 13:00:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 14:06:14 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 14:11:15 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b6bf535854df1a3abfc70c64387c8c6beeb67d9f
Cr-Commit-Position: refs/heads/master@{#438159}

Powered by Google App Engine
This is Rietveld 408576698