DevTools: [Persistence] green checkmark icons should not be editable

DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman

Committed: https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24
Cr-Commit-Position: refs/heads/master@{#438016}

[lushnikov, 2016-12-10 03:57:09]

please, take a look

[lushnikov, 2016-12-10 03:57:23]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 03:57:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-10 04:14:07]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 04:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 05:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 05:49:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lushnikov, 2016-12-12 19:01:33]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 19:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 21:05:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[dgozman, 2016-12-12 22:08:23]

lgtm

[lushnikov, 2016-12-12 22:12:40]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-12 22:14:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:38:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-12-13 01:43:48]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:44:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:10:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481593428223150,
"parent_rev": "f4b704c0a98886e4ae42989f40ea56147b22de90", "commit_rev":
"8d9e3f90b74aed24ded610790c1024d38d6435a8"}

[commit-bot: I haz the power, 2016-12-13 03:11:21]

Description was changed from

==========
DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman
==========

to

==========
DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2568623002
==========

[commit-bot: I haz the power, 2016-12-13 03:11:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 03:13:38]

Description was changed from

==========
DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2568623002
==========

to

==========
DevTools: [Persistence] green checkmark icons should not be editable

Today, navigator renders green checkmarks as a part of the title element.
This results in the editing field spanning over the icon as well.

This patch starts using treeelement.setTrailingIcons() method to
avoid this problem.

BUG=673086
R=dgozman

Committed: https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24
Cr-Commit-Position: refs/heads/master@{#438016}
==========

[commit-bot: I haz the power, 2016-12-13 03:13:39]

Patchset 2 (id:??) landed as
https://crrev.com/d722a94d485ea9774e89678a1a8a74e56a42fc24
Cr-Commit-Position: refs/heads/master@{#438016}