Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2568623002: DevTools: [Persistence] green checkmark icons should not be editable (Closed)
Patch Set: fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
index 318003413833a5faa57f3fedf5a6e6ab05be3eca..3eaa38dbf5239769acfce3b60487ef81c2a70bd6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
@@ -1268,16 +1268,15 @@ Sources.NavigatorUISourceCodeTreeNode = class extends Sources.NavigatorTreeNode
(this._uiSourceCode.isDirty() || Persistence.persistence.hasUnsavedCommittedChanges(this._uiSourceCode)))
titleText = '*' + titleText;
+ this._treeElement.title = titleText;
+
var binding = Persistence.persistence.binding(this._uiSourceCode);
if (binding && Runtime.experiments.isEnabled('persistence2')) {
- var titleElement = createElement('span');
- titleElement.textContent = titleText;
- var icon = UI.Icon.create('smallicon-checkmark', 'mapped-file-checkmark');
+ var icon = UI.Icon.create('smallicon-green-checkmark');
icon.title = Persistence.PersistenceUtils.tooltipForUISourceCode(this._uiSourceCode);
- titleElement.appendChild(icon);
- this._treeElement.title = titleElement;
+ this._treeElement.setTrailingIcons([icon]);
} else {
- this._treeElement.title = titleText;
+ this._treeElement.setTrailingIcons([]);
}
var tooltip = this._uiSourceCode.url();

Powered by Google App Engine
This is Rietveld 408576698