Presubmit: Skip third_party for fwd decl warning

Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest

Committed: https://crrev.com/2c51e821a6219d233cf63985373e989827ecd0f0
Cr-Commit-Position: refs/heads/master@{#437833}

[jbriance, 2016-12-09 12:32:21]

jbriance@cisco.com changed reviewers:
+ jochen@chromium.org

[jbriance, 2016-12-09 12:32:21]

While trying to upgrade third_party/protobuf
(https://codereview.chromium.org/2495533002/), I bumped into presubmit warnings
in autogenerated header files.
I think it is better to skip third_party for this presubmit check.

[jochen (gone - plz use gerrit), 2016-12-09 15:10:23]

would it make sense to still include third_party/WebKit as that's effectively
first-party?

[jbriance, 2016-12-09 15:23:09]

On 2016/12/09 15:10:23, jochen wrote:
> would it make sense to still include third_party/WebKit as that's effectively
> first-party?

Good point, it's first-party and moreover, the work has been already done
(https://codereview.chromium.org/2542203004/)
I'll upload a 2nd patch set soon

[jbriance, 2016-12-09 15:26:13]

Description was changed from

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party. Take the opportunity to
fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest
==========

to

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest
==========

[jbriance, 2016-12-09 15:26:29]

PTAL

[jochen (gone - plz use gerrit), 2016-12-12 07:42:02]

lgtm with comment addressed

https://codereview.chromium.org/2568473002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2568473002/diff/20001/PRESUBMIT.py#newcode1600
PRESUBMIT.py:1600: not f.LocalPath().startswith('third_party\WebKit')):
I think you have to escape the backslash

[jbriance, 2016-12-12 08:07:42]

https://codereview.chromium.org/2568473002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2568473002/diff/20001/PRESUBMIT.py#newcode1600
PRESUBMIT.py:1600: not f.LocalPath().startswith('third_party\WebKit')):
On 2016/12/12 07:42:02, jochen wrote:
> I think you have to escape the backslash

Indeed, I'll fix.

[jbriance, 2016-12-12 08:11:15]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 08:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 08:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 08:19:13]

Dry run: This issue passed the CQ dry run.

[jbriance, 2016-12-12 08:20:03]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-12-12 08:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2568473002/#ps40001
(title: "Rebase + escape backslashes properly")

[commit-bot: I haz the power, 2016-12-12 08:20:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 08:24:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481530803497400,
"parent_rev": "cfa7b08e67d366c7a1e172e1fa7ca8d63090855b", "commit_rev":
"684308d9c6317226805fb8ec74c0d768baabb2ee"}

[commit-bot: I haz the power, 2016-12-12 08:25:03]

Description was changed from

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest
==========

to

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest

Review-Url: https://codereview.chromium.org/2568473002
==========

[commit-bot: I haz the power, 2016-12-12 08:25:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:11:04]

Description was changed from

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest

Review-Url: https://codereview.chromium.org/2568473002
==========

to

==========
Presubmit: Skip third_party for fwd decl warning

Skip presubmit warning when the introduced useless forward
declaration is made in third_party (with the exception of
blink). Take the opportunity to fix one test and style.

BUG=662195
TEST=PRESUBMIT_test.py ForwardDeclarationTest

Committed: https://crrev.com/2c51e821a6219d233cf63985373e989827ecd0f0
Cr-Commit-Position: refs/heads/master@{#437833}
==========

[commit-bot: I haz the power, 2016-12-12 15:11:05]

Patchset 3 (id:??) landed as
https://crrev.com/2c51e821a6219d233cf63985373e989827ecd0f0
Cr-Commit-Position: refs/heads/master@{#437833}