Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2568173002: [interpreter][stubs] Don't modify FLAG_csa_verify flag to make TSAN happy. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter][stubs] Don't modify FLAG_csa_verify flag to make TSAN happy. BUG= Committed: https://crrev.com/769442a1b8257211a913d7a5cfb85362120b6f18 Cr-Commit-Position: refs/heads/master@{#41653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M src/builtins/builtins.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-12 16:48:09 UTC) #4
rmcilroy
LGTM. Any plan for how we will re-enable the verifier for the interpreter, or are ...
4 years ago (2016-12-12 16:50:14 UTC) #6
Igor Sheludko
On 2016/12/12 16:50:14, rmcilroy wrote: > LGTM. > > Any plan for how we will ...
4 years ago (2016-12-12 16:52:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568173002/1
4 years ago (2016-12-12 16:53:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 17:03:02 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 17:21:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/769442a1b8257211a913d7a5cfb85362120b6f18
Cr-Commit-Position: refs/heads/master@{#41653}

Powered by Google App Engine
This is Rietveld 408576698