Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: src/interpreter/interpreter.cc

Issue 2568173002: [interpreter][stubs] Don't modify FLAG_csa_verify flag to make TSAN happy. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index 82e5dd72fe02ef6e90c470bc184bba1c4714aa3f..d1fb8bc5ad5383770886f8a4f3985cb324a20cdd 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -98,12 +98,6 @@ void Interpreter::InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
BytecodeGeneratorFunc generator) {
if (!Bytecodes::BytecodeHasHandler(bytecode, operand_scale)) return;
- // TODO(ishell): remove this when code stub assembler graphs verification
- // is enabled for all stubs.
- bool sav_csa_verify = FLAG_csa_verify;
- // Enable verification only in mksnapshot.
- FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
-
InterpreterDispatchDescriptor descriptor(isolate_);
compiler::CodeAssemblerState state(
isolate_, zone, descriptor, Code::ComputeFlags(Code::BYTECODE_HANDLER),
@@ -118,7 +112,6 @@ void Interpreter::InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
CodeEventListener::BYTECODE_HANDLER_TAG,
AbstractCode::cast(*code),
Bytecodes::ToString(bytecode, operand_scale).c_str()));
- FLAG_csa_verify = sav_csa_verify;
}
Code* Interpreter::GetBytecodeHandler(Bytecode bytecode,
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698