Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2568143002: [ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:alert_coordinator to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:alert_coordinator to ARC. Semi-auto generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/587419001a0075528f670f430ca2b9569bde71db Cr-Commit-Position: refs/heads/master@{#438151}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -61 lines) Patch
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm View 2 chunks +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm View 1 8 chunks +26 lines, -57 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
stkhapugin
PTAL
4 years ago (2016-12-12 15:52:23 UTC) #4
noyau (Ping after 24h)
https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm (right): https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm#newcode16 ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm:16: // Variable backing properties of the same name. This ...
4 years ago (2016-12-12 15:55:58 UTC) #6
noyau (Ping after 24h)
lgtm once the comment is fixed.
4 years ago (2016-12-12 15:56:20 UTC) #7
stkhapugin
https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm (right): https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm#newcode16 ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm:16: // Variable backing properties of the same name. On ...
4 years ago (2016-12-12 16:39:50 UTC) #8
noyau (Ping after 24h)
On 2016/12/12 16:39:50, stkhapugin wrote: > https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm > File ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm (right): > > https://codereview.chromium.org/2568143002/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.mm#newcode16 > ...
4 years ago (2016-12-12 16:45:39 UTC) #9
stkhapugin
Done, thanks!
4 years ago (2016-12-12 18:20:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568143002/20001
4 years ago (2016-12-12 18:21:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/277978)
4 years ago (2016-12-13 01:57:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568143002/20001
4 years ago (2016-12-13 12:12:56 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 13:15:56 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-13 13:19:59 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/587419001a0075528f670f430ca2b9569bde71db
Cr-Commit-Position: refs/heads/master@{#438151}

Powered by Google App Engine
This is Rietveld 408576698