Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2568133002: cc: Only use single quad pass optimization when quad rect matches pass rect (Closed)

Created:
4 years ago by ajuma
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

cc: Only use single quad pass optimization when quad rect matches pass rect GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is positioned at (0, 0) in pass space, but this doesn't guarantee that the quad will be positioned at the top left corner of the pass' texture, since the pass' own texture isn't necessarily positioned at (0, 0) in pass space. In this situation, using the quad's texture in place of the pass's texture results in incorrect positioning of the quad's contents. To fix this, this CL adds a check that the quad rect matches the pass' output rect. BUG=671773 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2558393002 Cr-Commit-Position: refs/heads/master@{#437402} (cherry picked from commit 7faf8fc181b5d98c6007495a8944ff0be3aeeb90) Committed: https://chromium.googlesource.com/chromium/src/+/b51cb6ccaf15340a6fb968f61b907bd17fd15d81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A cc/test/data/translated_blue_green_alpha_gl.png View Binary file 0 comments Download
A cc/test/data/translated_blue_green_alpha_sw.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ajuma
4 years ago (2016-12-12 15:33:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b51cb6ccaf15340a6fb968f61b907bd17fd15d81.

Powered by Google App Engine
This is Rietveld 408576698