cc: Only use single quad pass optimization when quad rect matches pass rect

cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/7faf8fc181b5d98c6007495a8944ff0be3aeeb90
Cr-Commit-Position: refs/heads/master@{#437402}

[ajuma, 2016-12-08 20:06:43]

Description was changed from

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

BUG=671773
==========

to

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2016-12-08 20:06:58]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 20:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:51:25]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-12-08 22:32:38]

Description was changed from

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2016-12-08 22:33:37]

Description was changed from

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2016-12-08 22:33:37]

ajuma@chromium.org changed reviewers:
+ ericrk@chromium.org

[ericrk, 2016-12-08 23:44:07]

LGTM - thanks for taking care of this!

[ajuma, 2016-12-08 23:59:55]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:17:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481241595365350, "parent_rev":
"a1cb0f12c93540ee4fb8cb525b1a5cca2ac4494c", "commit_rev":
"fa84277c2a079a0edef45c8ff97f63854be12358"}

[commit-bot: I haz the power, 2016-12-09 01:17:47]

Description was changed from

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-12-09 01:17:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 01:20:27]

Description was changed from

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Only use single quad pass optimization when quad rect matches pass rect

GLRenderer::CanPassBeDrawnDirectly checks if a pass' only quad is
positioned at (0, 0) in pass space, but this doesn't guarantee that
the quad will be positioned at the top left corner of the pass' texture,
since the pass' own texture isn't necessarily positioned at (0, 0) in pass
space. In this situation, using the quad's texture in place of the pass's
texture results in incorrect positioning of the quad's contents. To fix this,
this CL adds a check that the quad rect matches the pass' output rect.

BUG=671773
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/7faf8fc181b5d98c6007495a8944ff0be3aeeb90
Cr-Commit-Position: refs/heads/master@{#437402}
==========

[commit-bot: I haz the power, 2016-12-09 01:20:28]

Patchset 1 (id:??) landed as
https://crrev.com/7faf8fc181b5d98c6007495a8944ff0be3aeeb90
Cr-Commit-Position: refs/heads/master@{#437402}