Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2568103002: Revert of Eagerly dispose of ScheduledActions. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eagerly dispose of ScheduledActions. (patchset #2 id:20001 of https://codereview.chromium.org/2552673002/ ) Reason for revert: Speculative revert for reported perf decrease on system_health.memory_mobile, https://crbug.com/672098 Original issue's description: > Eagerly dispose of ScheduledActions. > > The DOMTimer's ScheduledAction hold on to the script source and > state needed to execute the timer action. Let go of ShceduledAction's > resource early. > > Apart from reducing the lifetime of script source, this is a speculative > fix for crashes reported in v8::PersistentValueVector::Clear() during > lazy sweeping of ScheduledAction objects. > > R= > BUG= > > Committed: https://crrev.com/11bd50343795ed1dc1977da91e9a1588687522fd > Cr-Commit-Position: refs/heads/master@{#436298} TBR=oilpan-reviews@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/c0418c748e5eb8924d197edb934e2bbf123e0216 Cr-Commit-Position: refs/heads/master@{#437889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
Created Revert of Eagerly dispose of ScheduledActions.
4 years ago (2016-12-12 14:20:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568103002/1
4 years ago (2016-12-12 14:21:05 UTC) #3
haraken
LGTM
4 years ago (2016-12-12 15:27:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 16:36:37 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-12 16:40:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0418c748e5eb8924d197edb934e2bbf123e0216
Cr-Commit-Position: refs/heads/master@{#437889}

Powered by Google App Engine
This is Rietveld 408576698